From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/docker-engine: add disable pivot_root option
Date: Fri, 14 Jun 2019 09:10:42 +0200 [thread overview]
Message-ID: <87imt8hcb1.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <14308_1560493044_5D033BF4_14308_222_1_20190614061722.GA2485@r-lnx-nyma7486-2> (yann morin's message of "Fri, 14 Jun 2019 08:17:22 +0200")
>>>>> <yann.morin@orange.com> writes:
> Frank, All,
> On 2019-06-13 23:47 +0300, Frank Sigalas spake thusly:
>> Sets the environment variable DOCKER_RAMDISK before starting dockerd.
> [--SNIP--]
>> diff --git a/package/docker-engine/S60dockerd-ramdisk b/package/docker-engine/S60dockerd-ramdisk
>> new file mode 100644
>> index 0000000..a1092b6
>> --- /dev/null
>> +++ b/package/docker-engine/S60dockerd-ramdisk
>> @@ -0,0 +1,38 @@
>> +#!/bin/sh
>> +
>> +NAME=dockerd
>> +DAEMON=/usr/bin/$NAME
>> +PIDFILE=/var/run/$NAME.pid
>> +DAEMON_ARGS=""
>> +
>> +[ -r /etc/default/$NAME ] && . /etc/default/$NAME $1
> The existing package/docker-engine/S60dockerd script also parses
> similarly named file, so why can't you provide (e.g. in an overlay) this
> configuraiton file taht would just contain:
> export DOCKER_RAMDISK=1
> The config files in /etc/default/ are the place where such local
> customisations mustr be done.
> Besides, your solution does not cover the systemd case anyway (for which
> Christian alrady provided an example). But that is not even needed
> either, because this is still a local customisation.
Yes, I wonder if running dockerd from an initramfs is really such a
common setup that we want a dedicated option for it rather than just
letting people add such customization in their overlay?
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-06-14 7:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-13 20:47 [Buildroot] [PATCH 1/1] package/docker-engine: add disable pivot_root option Frank Sigalas
2019-06-13 23:36 ` Christian Stewart
2019-06-14 6:17 ` yann.morin at orange.com
2019-06-14 7:10 ` Peter Korsgaard [this message]
2019-06-14 7:22 ` Fragkiskos Sigalas
2019-06-14 8:36 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imt8hcb1.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox