From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH for-next 2/3] package/swig: enable PCRE regex matching in host-swig
Date: Sat, 01 Jun 2019 10:44:46 +0200 [thread overview]
Message-ID: <87imtpvgn5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190601092802.2b4102ac@windsurf> (Thomas Petazzoni's message of "Sat, 1 Jun 2019 09:28:02 +0200")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello,
> +Arnout, Yann, Peter in Cc.
> On Wed, 29 May 2019 17:16:54 +0200
> Romain Naour <romain.naour@gmail.com> wrote:
>> The upcoming ogre package needs a host swig binary with PCRE
>> regex support.
>>
>> Signed-off-by: Romain Naour <romain.naour@gmail.com>
>> ---
>> package/swig/swig.mk | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
> I never really like the addition of mandatory host package dependencies
> just for the sake of one use case. I was considering adding a hidden
> BR2_PACKAGE_HOST_PCRE option for this, but since pcre takes only 17
> seconds to build, maybe it was not worth the effort. So I've applied to
> next as-is, but I'd be interested to know what Arnout/Peter/Yann thing
> about adding a hidden BR2_PACKAGE_HOST_PCRE hidden option for that kind
> of situation. We had decided to not systematically add such options in
> all host packages, but that we could add some in a case-by-case basis.
> This case-by-case basis however will look "weird": ogre would have
> host-swig in its <pkg>_DEPENDENCIES, but in Config.in would select
> BR2_PACKAGE_HOST_PCRE and not BR2_PACKAGE_HOST_SWIG. This could start
> getting a bit clunky.
I think just having it unconditionally enabled is OK for now.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-06-01 8:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-29 15:16 [Buildroot] [PATCH for-next 1/3] package/zziplib: new package Romain Naour
2019-05-29 15:16 ` [Buildroot] [PATCH for-next 2/3] package/swig: enable PCRE regex matching in host-swig Romain Naour
2019-06-01 7:28 ` Thomas Petazzoni
2019-06-01 8:44 ` Peter Korsgaard [this message]
2019-06-01 11:09 ` Yann E. MORIN
2019-06-04 20:21 ` Arnout Vandecappelle
2019-05-29 15:16 ` [Buildroot] [PATCH for-next 3/3] package/ogre: new package Romain Naour
2019-06-01 9:24 ` Thomas Petazzoni
2019-06-01 22:00 ` Romain Naour
2019-10-27 15:44 ` Thomas Petazzoni
2019-06-01 7:22 ` [Buildroot] [PATCH for-next 1/3] package/zziplib: " Thomas Petazzoni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imtpvgn5.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox