From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] utils/test-pkg: Generate package config if it is not specified
Date: Wed, 27 Mar 2019 10:43:49 +0100 [thread overview]
Message-ID: <87imw4tzxm.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190317102736.51bd10fb@windsurf> (Thomas Petazzoni's message of "Sun, 17 Mar 2019 10:27:36 +0100")
>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@bootlin.com> writes:
> Hello Vadim,
> On Fri, 1 Mar 2019 14:33:42 +0200
> Vadim Kochan <vadim4j@gmail.com> wrote:
>> From: Vadim Kochan <vadim4j@gmail.com>
>>
>> It is possible to generate one-line config for the package just by
>> normalize it to the form:
>>
>> BR2_PACKAGE_${pkg_replaced-to_and_uppercase}
>>
>> it simplifes a bit of testing package where no additional config options
>> are needed.
>>
>> Signed-off-by: Vadim Kochan <vadim4j@gmail.com>
>> ---
>> utils/test-pkg | 17 ++++++++++++++++-
>> 1 file changed, 16 insertions(+), 1 deletion(-)
> Applied to master, thanks. I was initially a bit skeptical because if
> the package has a dependency, your solution does not work very well,
> and users could believe that the package is going to be tested while it
> won't. But in fact in that case all tests are going to be "SKIPPED"
> because the BR2_PACKAGE_FOO=y line is not in the final .config. This
> will clearly tell the user that much not testing has happened. So I'm
> fine with this, and therefore I applied.
While this isn't a bugfix, it seems quite safe and can be useful for
users - So I've committed it to 2019.02.x as well, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2019-03-27 9:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-01 12:33 [Buildroot] [PATCH 1/1] utils/test-pkg: Generate package config if it is not specified Vadim Kochan
2019-03-04 7:34 ` Arnout Vandecappelle
2019-03-17 9:27 ` Thomas Petazzoni
2019-03-27 9:43 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87imw4tzxm.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox