From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] eigen: Fix pkg-config file prefix error
Date: Fri, 17 Aug 2018 19:19:41 +0200 [thread overview]
Message-ID: <87in48oqqa.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20180816221620.30881-1-flatmax@flatmax.com> (Matt Flax's message of "Fri, 17 Aug 2018 08:16:20 +1000")
>>>>> "Matt" == Matt Flax <flatmax@flatmax.com> writes:
> From: Matt Flax <flatmax@flatmax.org>
> eigen generates a pkg-config file which has a broken prefix. This broken
> prefix causes an incorrect path when other packages call
> pkg-config --cflags eigen
It wasn't clear from the description what this broken prefix was, so I
had a look:
grep '^prefix=' build/eigen-3.3.4/eigen3.pc.in
prefix=@CMAKE_INSTALL_PREFIX@
Which is indeed no good.
> This patch fixes the prefix in the generated eigen pc file and prjects
> which depend on this pc file can now path correctly to the eigen include
> directory at build time.
> Signed-off-by: Matt Flax <flatmax@flatmax.org>
> ---
> package/eigen/eigen.mk | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
> diff --git a/package/eigen/eigen.mk b/package/eigen/eigen.mk
> index 89f54fb..84e6f3a 100644
> --- a/package/eigen/eigen.mk
> +++ b/package/eigen/eigen.mk
> @@ -23,7 +23,8 @@ endif
> # Generate the .pc file at build time
> define EIGEN_BUILD_CMDS
> sed -r -e 's,^Version: .*,Version: $(EIGEN_VERSION),' \
> - -e 's,^Cflags: .*,Cflags: -I$(EIGEN_DEST_DIR),' \
> + -e 's,^Cflags: .*,Cflags: -I$$\{prefix\}\/include\/eigen3,' \
> + -e 's,^prefix.*,prefix=\/usr,' \
Why are you escaping these '/' characters? The sed invocation uses , as
seperator, so / isn't special.
Committed with these backslashes dropped and the commit message tweaked,
thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-08-17 17:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 22:16 [Buildroot] [PATCH 1/1] eigen: Fix pkg-config file prefix error Matt Flax
2018-08-17 17:19 ` Peter Korsgaard [this message]
2018-08-24 8:47 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87in48oqqa.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox