Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] gcc: remove 4.5.x
Date: Wed, 24 Feb 2016 21:02:40 +0100	[thread overview]
Message-ID: <87io1d3mhr.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1456336840-14890-2-git-send-email-gustavo@zacarias.com.ar> (Gustavo Zacarias's message of "Wed, 24 Feb 2016 15:00:40 -0300")

>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:

 > It's been deprecated for some time now.
 > Signed-off-by: Gustavo Zacarias <gustavo@zacarias.com.ar>
 > ---
 >  Config.in.legacy           |  9 +++++++++
 >  package/gcc/Config.in.host | 26 --------------------------
 >  2 files changed, 9 insertions(+), 26 deletions(-)

 > diff --git a/Config.in.legacy b/Config.in.legacy
 > index 081bacd..7d2e5e7 100644
 > --- a/Config.in.legacy
 > +++ b/Config.in.legacy
 > @@ -143,6 +143,15 @@ comment "----------------------------------------------------"
 >  endif
 
 >  ###############################################################################
 > +comment "Legacy options removed in 2016.05"
 > +
 > +config BR2_GCC_VERSION_4_5_X
 > +	bool "gcc 4.5.x has been removed"
 > +	select BR2_LEGACY
 > +	help
 > +	  The 4.5.x version of gcc has been removed. Use a newer
 > +	  version instead.
 > +
 >  comment "Legacy options removed in 2016.02"
 
 >  config BR2_PACKAGE_DOVECOT_BZIP2
 > diff --git a/package/gcc/Config.in.host b/package/gcc/Config.in.host
 > index c677c65..f86a12e 100644
 > --- a/package/gcc/Config.in.host
 > +++ b/package/gcc/Config.in.host
 > @@ -13,31 +13,6 @@ choice
 >  	help
 >  	  Select the version of gcc you wish to use.
 
 > -	config BR2_GCC_VERSION_4_5_X
 > -		bool "gcc 4.5.x"
 > -		depends on BR2_DEPRECATED_SINCE_2015_05
 > -		# Broken or unsupported architectures
 > -		depends on !BR2_microblaze && !BR2_aarch64 && !BR2_arc \
 > -			&& !BR2_powerpc64le && !BR2_nios2
 > -		# Broken or unsupported ARM cores
 > -		depends on !BR2_cortex_a7 && !BR2_cortex_a12 && \
 > -			!BR2_cortex_a15 && !BR2_fa526 && !BR2_pj4

This doesn't apply (seems like you you don't have the commit adding the
A17 ARM variant), and you forgot to remove our gcc patches.

What do we do with our 4.5 based external toolchains and
BR2_TOOLCHAIN_GCC_AT_LEAST_4_5 (used by directfb)?

Care to send a v2?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2016-02-24 20:02 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 18:00 [Buildroot] [PATCH 1/2] gcc: mark 4.7.x as deprecated Gustavo Zacarias
2016-02-24 18:00 ` [Buildroot] [PATCH 2/2] gcc: remove 4.5.x Gustavo Zacarias
2016-02-24 20:02   ` Peter Korsgaard [this message]
2016-02-24 20:26     ` Gustavo Zacarias
2016-02-25  9:48     ` Thomas Petazzoni
2016-02-25  9:57       ` Peter Korsgaard
2016-02-25 10:03         ` Thomas Petazzoni
2016-02-25 10:53         ` Gustavo Zacarias
2016-02-25 12:43           ` Thomas Petazzoni
2016-02-25 12:48             ` Gustavo Zacarias
2016-02-24 19:59 ` [Buildroot] [PATCH 1/2] gcc: mark 4.7.x as deprecated Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87io1d3mhr.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox