Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/avahi: enable libavahi-client support
Date: Sun, 02 Nov 2014 23:51:15 +0100	[thread overview]
Message-ID: <87ioix43oc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1414800623-7721-1-git-send-email-jkrause@posteo.de> ("Jörg Krause"'s message of "Sat, 1 Nov 2014 01:10:23 +0100")

>>>>> "J?rg" == J?rg Krause <jkrause@posteo.de> writes:

 > Some packages needs libavahi-client support which is autobuild by avahi if
 > avahi-daemon and dbus is selected. To select libavahi-client explicitly makes
 > this dependency more obvious for dependent packages.

 > libdns_sd is only build by avahi if libavahi-client is present (and 
 > `--enable-compat-libdns_sd` is set as configure option). So it's safe to 
 > depend on libavahi-client instead of avahi-daemon.

Having a user visible option for this is a bit odd as it cannot be used
to DISABLE the library.

Perhaps it should just be a hidden helper option for other packages
instead? (so drop the bool and help text)

 > Signed-off-by: J?rg Krause <jkrause@posteo.de>
 > ---
 >  package/avahi/Config.in | 10 ++++++++--
 >  1 file changed, 8 insertions(+), 2 deletions(-)

 > diff --git a/package/avahi/Config.in b/package/avahi/Config.in
 > index b52cc78..56b372e 100644
 > --- a/package/avahi/Config.in
 > +++ b/package/avahi/Config.in
 > @@ -35,11 +35,17 @@ config BR2_PACKAGE_AVAHI_DAEMON
 >  	  The daemon registers local IP addresses and services using
 >  	  mDNS/DNS-SD.
 
 > -config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
 > -	bool "libdns_sd compatibility (Bonjour)"
 > +config BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
 > +	bool "libavahi-client"
 >  	depends on BR2_PACKAGE_AVAHI_DAEMON
 >  	select BR2_PACKAGE_DBUS
 >  	help
 > +	  Enable the Avahi client library.
 > +
 > +config BR2_PACKAGE_AVAHI_LIBDNSSD_COMPATIBILITY
 > +	bool "libdns_sd compatibility (Bonjour)"
 > +	depends on BR2_PACKAGE_AVAHI_LIBAVAHI_CLIENT
 > +	help
 >  	  Enable the libdns_sd (Bonjour) compatibility library support
 >  	  for legacy applications.
 
 > -- 
 > 2.1.3

 > _______________________________________________
 > buildroot mailing list
 > buildroot at busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2014-11-02 22:51 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-11-01  0:10 [Buildroot] [PATCH 1/1] package/avahi: enable libavahi-client support Jörg Krause
2014-11-02 22:51 ` Peter Korsgaard [this message]
2014-11-03 11:31   ` Jörg Krause

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ioix43oc.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox