From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] linux: add support for 3.x and -rc versions
Date: Thu, 14 Jul 2011 12:28:39 +0200 [thread overview]
Message-ID: <87ipr5cg14.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1310632596.2068.3.camel@sven> (Sven Neumann's message of "Thu, 14 Jul 2011 10:36:36 +0200")
>>>>> "Sven" == Sven Neumann <s.neumann@raumfeld.com> writes:
Hi,
Sven> I've updated to latest git today and ran into this error:
Sven> linux/linux.mk:26: *** Recursive variable `LINUX_SITE' references itself
Sven> (eventually). Stop.
Interesting, I haven't seen that here. What make version are you using?
I just built qemu_arm_versatile_defconfig with make 3.81 without any
problems. Could you post your config, please?
Sven> For now I've solved this by the following (somewhat inelegant) change:
I think we can simply replace one of the '=' with a := to break the
loop, but would like to be able to reproduce it first.
Sven> I also think that the logic for selecting a custom tarball is wrong.
Sven> Shouldn't this rather be changed like this:
Sven> diff --git a/linux/linux.mk b/linux/linux.mk
Sven> index 88fe6dd..35a228a 100644
Sven> --- a/linux/linux.mk
Sven> +++ b/linux/linux.mk
Sven> @@ -6,7 +6,7 @@
Sven> LINUX_VERSION=$(call qstrip,$(BR2_LINUX_KERNEL_VERSION))
Sven> # Compute LINUX_SOURCE and LINUX_SITE from the configuration
Sven> -ifeq ($(LINUX_VERSION),custom)
Sven> +ifeq ($(BR2_LINUX_KERNEL_CUSTOM_TARBALL),y)
Sven> LINUX_TARBALL = $(call qstrip,$(BR2_LINUX_KERNEL_CUSTOM_TARBALL_LOCATION))
As far as I can see those should be equivalent as LINUX_VERSION is:
default "custom" if BR2_LINUX_KERNEL_CUSTOM_TARBALL
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2011-07-14 10:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-07-11 21:46 [Buildroot] [git commit] linux: add support for 3.x and -rc versions Thomas Petazzoni
2011-07-14 8:36 ` Sven Neumann
2011-07-14 10:28 ` Peter Korsgaard [this message]
2011-07-14 14:29 ` Sven Neumann
2011-07-14 14:46 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2011-07-14 10:38 Quotient Remainder
2011-07-14 12:24 ` Quotient Remainder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ipr5cg14.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox