Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Allow file globs in microperl module list
Date: Thu, 10 Feb 2011 23:14:50 +0100	[thread overview]
Message-ID: <87ipwrfsf9.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1297356099-15765-1-git-send-email-mort@bork.org> (Martin Hicks's message of "Thu, 10 Feb 2011 11:41:39 -0500")

>>>>> "Martin" == Martin Hicks <mort@bork.org> writes:

 Martin> This lets the user place file globs into the microperl module
 Martin> list.  e.g.,

 Martin> CGI/*.pm warnings.pm strict.pm

 Martin> Signed-off-by: Martin Hicks <mort@bork.org>
 Martin> ---
 Martin>  package/microperl/microperl.mk |    3 ++-
 Martin>  1 files changed, 2 insertions(+), 1 deletions(-)

 Martin> diff --git a/package/microperl/microperl.mk b/package/microperl/microperl.mk
 Martin> index b68e825..71a4e4a 100644
 Martin> --- a/package/microperl/microperl.mk
 Martin> +++ b/package/microperl/microperl.mk
 Martin> @@ -82,7 +82,8 @@ ifneq ($(MICROPERL_MODS),)
 Martin>  	 for i in $(patsubst %,$(TARGET_DIR)/$(MICROPERL_MODS_DIR)/%,$(dir $(MICROPERL_MODS))); do \
 Martin>  		[ -d $$i ] || mkdir -p $$i; \
 Martin>  	 done; \
 Martin> -	 for i in $(MICROPERL_MODS); do \
 Martin> +	 FILES="$(shell cd $(MICROPERL_DIR)/lib && ls $(MICROPERL_MODS))"; \
 Martin> +	 for i in $$FILES; do \
 Martin>  	 cp -dpf $(MICROPERL_DIR)/lib/$$i $(TARGET_DIR)/$(MICROPERL_MODS_DIR)/$$i; \

Why not just do:

for i in $(addprefix $(MICROPERL_DIR)/lib/,$(MICROPERL_MODS)); do ..

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2011-02-10 22:14 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-02-10 16:41 [Buildroot] [PATCH] Allow file globs in microperl module list Martin Hicks
2011-02-10 22:14 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipwrfsf9.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox