From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Korsgaard Date: Thu, 30 Dec 2010 23:07:57 +0100 Subject: [Buildroot] commiting patches In-Reply-To: ("Daniel =?utf-8?Q?Nystr=C3=B6m=22's?= message of "Thu, 30 Dec 2010 22:04:13 +0100") References: <20101230063005.15755osot9w5qwco@www.home.zuerker.org> <8739pfhtgk.fsf@macbook.be.48ers.dk> Message-ID: <87ipyahq2q.fsf@macbook.be.48ers.dk> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: buildroot@busybox.net >>>>> "Daniel" == Daniel Nystr?m writes: Daniel> 2010/12/30 Peter Korsgaard : >> It's a big help when other developers help with the review and send >> their ack/nacks (thanks for this!), so those patches are often handled >> earlier than others. Daniel> How do you prefer the ack/nack? Just a reply with "+1" in mail Daniel> body? A "Signed-off-by: name " mail body? or the whole Daniel> patch resubmitted with the SoB-line added? I prefer an Acked-by: tag like it's done for the Linux kernel and a bunch of other projects using git (and like Thomas already does). -- Bye, Peter Korsgaard