Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v2] whetstone: new benchmark package
Date: Tue, 07 Dec 2010 15:43:07 +0100	[thread overview]
Message-ID: <87ipz5skxw.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1290235409-31995-1-git-send-email-vapier@gentoo.org> (Mike Frysinger's message of "Sat, 20 Nov 2010 01:43:29 -0500")

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

 Mike> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
 Mike> ---
 Mike> v2
 Mike> 	- tweak flag passing when building

 Mike> diff --git a/package/whetstone/Config.in b/package/whetstone/Config.in
 Mike> new file mode 100644
 Mike> index 0000000..7a68160
 Mike> --- /dev/null
 Mike> +++ b/package/whetstone/Config.in
 Mike> @@ -0,0 +1,6 @@
 Mike> +config BR2_PACKAGE_WHETSTONE
 Mike> +	bool "whetstone"
 Mike> +	help
 Mike> +	  C Converted Whetstone Double Precision Benchmark
 Mike> +
 Mike> +	  http://www.netlib.org/benchmark/
 Mike> diff --git a/package/whetstone/whetstone.mk b/package/whetstone/whetstone.mk
 Mike> new file mode 100644
 Mike> index 0000000..ab3c147
 Mike> --- /dev/null
 Mike> +++ b/package/whetstone/whetstone.mk
 Mike> @@ -0,0 +1,37 @@
 Mike> +#############################################################
 Mike> +#
 Mike> +# whetstone
 Mike> +#
 Mike> +#############################################################
 Mike> +
 Mike> +WHETSTONE_VERSION = 1.2
 Mike> +WHETSTONE_SOURCE = whetstone.c
 Mike> +WHETSTONE_SITE = http://www.netlib.org/benchmark/
 Mike> +
 Mike> +define WHETSTONE_BUILD_CMDS
 Mike> +	CFLAGS="$(TARGET_CFLAGS) -Wall -DNO_PROTOTYPES=1" \
 Mike> +	$(MAKE) \
 Mike> +		CC="$(TARGET_CC)" \
 Mike> +		LDLIBS="-lm" \
 Mike> +		-C $(@D) whetstone

Please don't add hardcoded cflags like -Wall. As it's a single file, I
would prefer to call $(TARGET_CC) directly instead of using make.

Also don't forget TARGET_LDFLAGS.

 Mike> +endef
 Mike> +
 Mike> +define WHETSTONE_CLEAN_CMDS
 Mike> +	rm -f $(@D)/whetstone
 Mike> +endef
 Mike> +
 Mike> +define WHETSTONE_INSTALL_TARGET_CMDS
 Mike> +	$(INSTALL) -D $(@D)/whetstone $(TARGET_DIR)/bin/whetstone

I would have expected it to get installed into /usr/bin

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-12-07 14:43 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-20  6:10 [Buildroot] [PATCH] whetstone: new benchmark package Mike Frysinger
2010-11-20  6:43 ` [Buildroot] [PATCH v2] " Mike Frysinger
2010-12-07 14:43   ` Peter Korsgaard [this message]
2010-12-07 21:05   ` [Buildroot] [PATCH v3] " Mike Frysinger
2010-12-08 22:34     ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ipz5skxw.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox