Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Rename BASE_DIR to OUTPUT_DIR
Date: Wed, 23 Sep 2009 13:09:27 +0200	[thread overview]
Message-ID: <87iqf9rk7s.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <200909231237.58227.mroth@nessie.de> (Michael Roth's message of "Wed\, 23 Sep 2009 12\:37\:52 +0200")

>>>>> "Michael" == Michael Roth <mroth@nessie.de> writes:

Hi,

 >> Hmm, this will presumably break downloads for people trying to reuse
 >> their existing .config? (E.G. DL_DIR gets to point to /dl).

 Michael> Hmm... Yes, I think you're right.

 >> I agree that BASE_DIR isn't the most telling name for what it does,
 >> but I'm not sure it's worth the trouble.

 Michael> OTOH: The introduced change to the directory hierarchy "broke"
 Michael> the download directory from '$(TOPDIR)/dl' to
 Michael> '$(TOPDIR)/output/dl'.

Yes, but the difference is that that change didn't cause a build
failure, only a slight inconvenience.

The same with staging moving from build_*/staging_dir -> staging, the
old location still works.

 Michael> Maybe the directory hierarchy change introduced some other
 Michael> inconvenience so maybe a big fat warning that some things
 Michael> changed in the documentation is the way to go?

Yes, we'll probably need that anyway.

 Michael> Or, maybe a hook in 'make oldconfig' could fix that?

I would prefer to not add extra code complexity for this (relative
minor) cleanup.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2009-09-23 11:09 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-23 10:03 [Buildroot] [PATCH] Rename BASE_DIR to OUTPUT_DIR Michael Roth
2009-09-23 10:22 ` Peter Korsgaard
2009-09-23 10:37   ` Michael Roth
2009-09-23 11:09     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqf9rk7s.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox