Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] qtopia4: fix wrong variable name for SQL
Date: Mon, 03 Nov 2008 13:25:17 +0100	[thread overview]
Message-ID: <87iqr5f13m.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <d6cda7730811030413j1761701by6efebb6897b59f9@mail.gmail.com> ("Thiago A. Corrêa"'s message of "Mon\, 3 Nov 2008 10\:13\:46 -0200")

>>>>> "Thiago" == Thiago A Corr?a <thiago.correa@gmail.com> writes:

Hi,

 Markus> I prefer inline patches, for easier commenting for example. I
 Markus> also find attachments are quite annoying if I have to use the
 Markus> web archives and can't just read the patch but have to
 Markus> download it at first. I know Peter prefers inline for the
 Markus> ease of applying them with "git am" and he has already
 Markus> applied a few from me.
 >> 
 >> Exactly!

 Thiago> I don't use git, and I guess I never will *smile*.

Pity, you're missing out on good stuff. It's quite easy to get started
with git-svn.

 Thiago> I agree it's best for commenting, but if it were also as well
 Thiago> easier to apply, then it means the submitter doesn't have to
 Thiago> wait for Peter to have the time to check it. I or someone
 Thiago> else with the same problem as me could do it.

patch -p1 < mail afaik still works, but then you ofcourse have to do
the manual svn add / copy commit message ritual.

 >> Thiago, what keeps you from using a proper email client?
 
 Thiago> I get rejects whenever I try to apply those git generated patches. It
 Thiago> just occured to me that maybe if I use the "show original" in the
 Thiago> gmail and copy from that it should work better. Will see in the next
 Thiago> patches if this works ;)

Do you apply them with patch -p1 ?

About cut'n'paste - Careful that you don't get tabs converted to white
space on the way.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-11-03 12:25 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-31  0:18 [Buildroot] [PATCH] qtopia4: fix wrong variable name for SQL Markus Heidelberg
2008-10-31  2:31 ` Thiago A. Corrêa
2008-11-01 11:09   ` Markus Heidelberg
2008-11-02 13:59     ` Peter Korsgaard
2008-11-03 12:13       ` Thiago A. Corrêa
2008-11-03 12:25         ` Peter Korsgaard [this message]
2008-11-04  0:45         ` Markus Heidelberg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87iqr5f13m.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox