Re: [Buildroot] [PATCH] .b4-config: add patchwork configuration

From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle <arnout@rnout.be>
Cc: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Subject: Re: [Buildroot] [PATCH] .b4-config: add patchwork configuration
Date: Sat, 10 Oct 2026 19:35:48 +0200	[thread overview]
Message-ID: <87jynpcvbf.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <b0c47736-e84d-424d-aa1d-0164454693ce@rnout.be> (Arnout Vandecappelle's message of "Sat, 10 Oct 2026 19:17:06 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@rnout.be> writes:

 > On 10/10/2026 16:55, Peter Korsgaard wrote:
 >>>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:
 >> > This allows maintainers to use b4 to update patchwork.
 >> > - Use git config --global b4.pw-key <key> to set the patchwork token.
 >> NIT: Why globally?

 >  No good reason.

 >>> - Use git config b4.thanks-am-template <filename> to point to a template
 >> >   for thank-you mails.
 >> > - Use b4 shazam -s -k <patchwork URL> to apply a patch and set it to
 >> >   "Under Review".
 >> > - Use b4 ty -a to prepare (and optionally send with -S) the thank-you
 >> >   mail, and update patchwork to "Accepted".
 >> It would maybe have been worth mentioning that this is a new feature
 >> in
 >> b4 0.15 and ignored by earlier versions.
 >  It works with my 0.14.3 in Fedora...

I'll give it another try, possibly I did something wrong. It is listed
in the 0.15 changelog though.

 >  BTW a few additional things I discovered:

 > - it doesn't do the From: rewriting like patchwork does. I do an
 >   additional sed to handle that;

 > - for the same reason, you have to add -S to correctly handle
 >   Reviewed-by etc. tags, otherwise it gives an error when the tag
 >  doesn't match the From;

 > - if the patch is part of a series, shazam downloads the entire series
 >   unless you give --single-message;

 > - b4 ty gives only a single reply to a series. It does mark everything
 >   as accepted in patchwork.

That part is probably OK, as long as the reply makes it clear that the
entire series is applied.

 >  So a bit of a mixed bag :-(. Time to patch b4?

Indeed. Maybe not a bad idea? It naturally does not fix it for the
distro packages for now though.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot