From: Peter Korsgaard <peter@korsgaard.com>
To: Bernd Kuhls <bernd.kuhls@t-online.de>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v2 1/3] package/vdr: Fix patch for uclibc build
Date: Wed, 14 Jun 2023 15:33:36 +0200 [thread overview]
Message-ID: <87jzw6p3rj.fsf@48ers.dk> (raw)
In-Reply-To: <20230516194855.1548486-1-bernd.kuhls@t-online.de> (Bernd Kuhls's message of "Tue, 16 May 2023 21:48:53 +0200")
>>>>> "Bernd" == Bernd Kuhls <bernd.kuhls@t-online.de> writes:
> uClibc-ng 1.0.42 added support for getloadavg:
> https://cgit.uclibc-ng.org/cgi/cgit/uclibc-ng.git/commit/?id=ad3a130dad88ad7a59dcd965b0cf9bd0d713595e
> leading to build errors of the vdr package:
> skinlcars.c:1105:12: error: 'int getloadavg(double*, int)' was declared 'extern' and later 'static' [-fpermissive]
> since its version bump in buildroot:
> https://git.busybox.net/buildroot/commit/?id=61ae6add9e5d4761536fa4ff24150d5f8f82a61d
> Fixes:
> http://autobuild.buildroot.net/results/d3a/d3a65044fabdafa1b6d75a508eae006a2cfebdc0/
> Signed-off-by: Bernd Kuhls <bernd.kuhls@t-online.de>
> ---
> I do not know whether all external toolchains were already updated to
> uClibc-ng >= 1.0.42 so I fixed the patch instead of removing it.
> Due to uClibc-ng providing getloadavg() sending 0001-getloadavg.patch
> makes no sense imho.
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-06-14 13:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-16 19:48 [Buildroot] [PATCH v2 1/3] package/vdr: Fix patch for uclibc build Bernd Kuhls
2023-05-16 19:48 ` [Buildroot] [PATCH 2/3] package/vdr: reformatted patches Bernd Kuhls
2023-06-14 13:33 ` Peter Korsgaard
2023-05-16 19:48 ` [Buildroot] [PATCH v2 3/3] package/vdr: fix musl build Bernd Kuhls
2023-06-14 13:33 ` Peter Korsgaard
2023-06-03 19:53 ` [Buildroot] [PATCH v2 1/3] package/vdr: Fix patch for uclibc build Arnout Vandecappelle via buildroot
2023-06-14 13:33 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87jzw6p3rj.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=bernd.kuhls@t-online.de \
--cc=buildroot@buildroot.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox