From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables
Date: Tue, 05 Feb 2019 14:25:04 +0100 [thread overview]
Message-ID: <87k1ienz9r.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190205110342.29725-1-patrickdepinguin@gmail.com> (Thomas De Schampheleire's message of "Tue, 5 Feb 2019 12:03:42 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin@gmail.com> writes:
> From: Thomas De Schampheleire <thomas.de_schampheleire@nokia.com>
> Some package builds may fail when environment variables are present with the
> same names as make variables in a package. This is a bigger problem for
> environment variables with generic names, like 'PLATFORM' and 'OS'.
> 'PLATFORM' is for example a problem for host-acl.
I'm OK with the patch, but what is the error exactly for host-acl? I
don't seem to see any reference to the string 'PLATFORM' in host-acl:
make host-acl-patch
grep -rs PLATFORM build/host-acl-2.2.53
build/host-acl-2.2.53/build-aux/ltmain.sh: v.dwPlatformId == VER_PLATFORM_WIN32_NT;
build/host-acl-2.2.53/build-aux/ltmain.sh.orig: v.dwPlatformId == VER_PLATFORM_WIN32_NT;
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-02-05 13:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-05 11:03 [Buildroot] [PATCH] Makefile: unexport 'PLATFORM' and 'OS' environment variables Thomas De Schampheleire
2019-02-05 13:25 ` Peter Korsgaard [this message]
2019-02-05 14:22 ` Peter Korsgaard
2019-02-18 16:15 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1ienz9r.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox