From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] fix host-openssl binary installation
Date: Fri, 19 Feb 2016 11:18:21 +0100 [thread overview]
Message-ID: <87k2m1huky.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <CAJjDOTnPLk-zo4+fxFtrbfUCWo+q9fcHcPE3fRQxUscXHkfjKA@mail.gmail.com> (matthew amlogic shyu's message of "Thu, 18 Feb 2016 09:05:09 +0800")
>>>>> "matthew" == matthew amlogic shyu <matthew.shyu.amlogic@gmail.com> writes:
Hi,
>> > The Configure script in openssl takes install_prefix from env by default
>> > $install_prefix= "$ENV{'INSTALL_PREFIX'}"
>> > However, the INSTALL_PREFIX points to *TARGET* folder instead of
>> > *HOST* folder.
>> > This is fixed by intentionally setting install_prefix to blank.
>>
>> Sorry, I'm not following you here. Do you mean that you have exported
>> INSTALL_PREFIX=<something> in your environment outside Buildroot? We do
>> indeed pass INSTALL_PREFIX to make install when we install the target
>> version to staging/target, but I don't see the relation to the host
>> variant?
> Yes, the INSTALL_PREFIX env is passed in from buildroot. However, as
> you said, it points to output/staging/usr. For host variant, the correct
> installation path should be output/host/usr, which is set by --prefix. The
> idea of this patch is for host-openssl not to use --install-prefix but to
> use --prefix.
But we only pass INSTALL_PREFIX=$(STAGING_DIR)/usr during the
make-install-to-staging step, and not when we configure/build/install
the host variant:
define OPENSSL_INSTALL_STAGING_CMDS
$(MAKE) -C $(@D) INSTALL_PREFIX=$(STAGING_DIR) install
endef
define HOST_OPENSSL_INSTALL_CMDS
$(MAKE) -C $(@D) install
endef
define OPENSSL_INSTALL_TARGET_CMDS
$(MAKE) -C $(@D) INSTALL_PREFIX=$(TARGET_DIR) install
rm -rf $(TARGET_DIR)/usr/lib/ssl
rm -f $(TARGET_DIR)/usr/bin/c_rehash
endef
So I'm still not sure what you are trying to solve?
--
Venlig hilsen,
Peter Korsgaard
next prev parent reply other threads:[~2016-02-19 10:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-17 10:41 [Buildroot] [PATCH 1/1] fix host-openssl binary installation Matthew Shyu
2016-02-17 15:02 ` Peter Korsgaard
2016-02-18 1:05 ` matthew.amlogic shyu
2016-02-19 10:18 ` Peter Korsgaard [this message]
2016-02-19 10:33 ` matthew.amlogic shyu
2016-02-19 10:36 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2m1huky.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox