From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [git commit] edid-decode: new package
Date: Wed, 09 Dec 2015 22:51:08 +0100 [thread overview]
Message-ID: <87k2onl29f.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <56682A57.4090207@imgtec.com> (Vicente Olivert Riera's message of "Wed, 9 Dec 2015 13:19:19 +0000")
>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:
> Hello Peter,
> $(TARGET_MAKE_ENV) should have been used before $(MAKE), as I said in my
> review for this patch:
> http://patchwork.ozlabs.org/patch/553537/
Strange, I didn't see your mail when I applied the patch - My mail has
been acting up a bit.
TARGET_MAKE_ENV doesn't really matter here as it doesn't call anything
else than $CC / mkdir / install, but I'll add it for consistency and in
case future versions do.
Thanks for the review!
--
Venlig hilsen,
Peter Korsgaard
prev parent reply other threads:[~2015-12-09 21:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-12-09 13:15 [Buildroot] [git commit] edid-decode: new package Peter Korsgaard
2015-12-09 13:19 ` Vicente Olivert Riera
2015-12-09 21:51 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2onl29f.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox