From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] package/dhrystone: fix musl compilation issue
Date: Sun, 13 Sep 2015 23:13:12 +0200 [thread overview]
Message-ID: <87k2ruauqf.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1441111142-8561-1-git-send-email-brendanheading@gmail.com> (Brendan Heading's message of "Tue, 1 Sep 2015 13:39:02 +0100")
>>>>> "Brendan" == Brendan Heading <brendanheading@gmail.com> writes:
> Fixes:
> http://autobuild.buildroot.net/results/1b6cb1b40431bf484db2d99bfdc8237cbae6a9d7/
> http://autobuild.buildroot.net/results/20e669d6e4bc3d872a355ef658ddad8f34676624/
> Include a more appropriate header file to pick up the definition of HZ
> from the kernel headers.
> Signed-off-by: Brendan Heading <brendanheading@gmail.com>
> ---
> v1 - This looks a bit hacky, but it seems to compile fine against
> the uclibc, glibc and musl toolchain combos without any other packages
> enabled. Comments welcome.
Looking at the implementation I see we end up using the times(2)
interface, which returns clock_t values. The kernel defines clock_t in
terms of USER_HZ which is always 100 (see kernel/time/time.c::jiffies_to_clock_t()).
So it is simpler to just pass -DHZ=100 to dhrystone.
So I have committed a fix to do so instead, thanks.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2015-09-13 21:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-09-01 12:39 [Buildroot] [PATCH 1/1] package/dhrystone: fix musl compilation issue Brendan Heading
2015-09-13 21:13 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k2ruauqf.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox