Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] ntp: drop uselss patch fixup which sometimes breaks rebuild
Date: Mon, 06 Jul 2015 09:52:34 +0200	[thread overview]
Message-ID: <87k2udsoxp.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1436129545-3540-1-git-send-email-danomimanchego123@gmail.com> (Danomi Manchego's message of "Sun, 5 Jul 2015 16:52:25 -0400")

>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

 > Drop sed line which no longer changes anything.  Worse, it bumps each
 > ntpd/*.c file's modification time, which sometimes triggers a strange
 > dependency path causing the makefile to attempt to run the ntpd keyword-gen
 > app, which fails, because it's been cross-compiled.

 > Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>

Makes sense, and the affected code has indeed been changed upstream so
it doesn't do anything sensible any more. From CommitLog:

  ntpd/cmd_args.c at 1.56.1.3 +2 -3
    remove unused leftover global specific_interface.
    rindex() -> strrchr()

Committed, thanks.

-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2015-07-06  7:52 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-07-05 20:52 [Buildroot] [PATCH 1/1] ntp: drop uselss patch fixup which sometimes breaks rebuild Danomi Manchego
2015-07-05 22:08 ` Yann E. MORIN
2015-07-06  1:59   ` Danomi Manchego
2015-07-06  7:51   ` Peter Korsgaard
2015-07-06  7:52 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k2udsoxp.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox