From mboxrd@z Thu Jan  1 00:00:00 1970
From: Peter Korsgaard <jacmet@uclibc.org>
Date: Sat, 19 May 2012 23:46:17 +0200
Subject: [Buildroot] [PATCH 1/3] Convert gettext to autotargets
In-Reply-To: <1336475958-5714-1-git-send-email-s.martin49@gmail.com> (Samuel
 Martin's message of "Tue, 8 May 2012 13:19:16 +0200")
References: <4F7C6130.102@free-electrons.com>
 <1336475958-5714-1-git-send-email-s.martin49@gmail.com>
Message-ID: <87k407lu8m.fsf@macbook.be.48ers.dk>
List-Id: <buildroot.busybox.net>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: buildroot@busybox.net

>>>>> "Samuel" == Samuel Martin <s.martin49@gmail.com> writes:

Hi,

 Samuel> From: Maxime Ripard <maxime.ripard@free-electrons.com>
 Samuel> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
 Samuel> Acked-by: Samuel Martin <s.martin49@gmail.com>
 Samuel> ---

 Samuel> -$(GETTEXT_DIR)/$(GETTEXT_BINARY): $(GETTEXT_DIR)/.configured
 Samuel> -	$(MAKE) -C $(GETTEXT_DIR)
 Samuel> -	touch -c $(GETTEXT_DIR)/$(GETTEXT_BINARY)
 Samuel> +define GETTEXT_REMOVE_BINARIES
 Samuel> +	rm -f $(TARGET_DIR)/usr/bin/gettext
 Samuel> +	rm -f $(TARGET_DIR)/usr/bin/gettext.sh
 Samuel> +	rm -f $(TARGET_DIR)/usr/bin/gettextize
 Samuel> +endef

 Samuel>  ifeq ($(BR2_PACKAGE_LIBINTL),y)
 Samuel> +	GETTEXT_POST_INSTALL_TARGET_HOOKS += GETTEXT_REMOVE_BINARIES
 Samuel>  endif
 Samuel> +

This seems backwards. Wouldn't you want to keep the binaries if libintl
is enabled?

-- 
Bye, Peter Korsgaard