From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 5 v6] dependencies: check minimal make version early on
Date: Thu, 09 Feb 2012 22:05:56 +0100 [thread overview]
Message-ID: <87k43v4szv.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <524d33227f44ddf99ac9.1328718137@beantl019720> (Thomas De Schampheleire's message of "Wed, 08 Feb 2012 17:22:17 +0100")
>>>>> "Thomas" == Thomas De Schampheleire <patrickdepinguin+buildroot@gmail.com> writes:
Thomas> Although support/dependencies/dependencies.sh checks for the
Thomas> version of make, this script doesn't get a chance to run if
Thomas> make encounters a syntax error as a result of being too old.
Thomas> export BR2_VERSION:=2012.02-git
Thomas> +# Check for minimal make version (note: this check will break
Thomas> at make 10.x)
Thomas> +MIN_MAKE_VERSION=3.81
Thomas> +ifeq (,$(filter $(MIN_MAKE_VERSION),$(firstword $(sort $(MAKE_VERSION) $(MIN_MAKE_VERSION)))))
It seems simpler to just compare with MAKE_VERSION, so I changed it to
be:
ifeq ($(firstword $(sort $(MAKE_VERSION) $(MIN_MAKE_VERSION))),$(MAKE_VERSION))
Committed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2012-02-09 21:05 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 16:22 [Buildroot] [PATCH 0 of 5 v6] dependencies: some improvements Thomas De Schampheleire
2012-02-08 16:22 ` [Buildroot] [PATCH 1 of 5 v6] dependencies: move from toolchain/ to support/ Thomas De Schampheleire
2012-02-09 20:59 ` Peter Korsgaard
2012-02-08 16:22 ` [Buildroot] [PATCH 2 of 5 v6] dependencies: check minimal make version early on Thomas De Schampheleire
2012-02-09 21:05 ` Peter Korsgaard [this message]
2012-02-09 21:57 ` Peter Korsgaard
2012-02-08 16:22 ` [Buildroot] [PATCH 3 of 5 v6] dependencies: add function suitable-host-package Thomas De Schampheleire
2012-02-09 22:18 ` Peter Korsgaard
2012-02-08 16:22 ` [Buildroot] [PATCH 4 of 5 v6] Makefile: change order of dirs and dependencies Thomas De Schampheleire
2012-02-09 21:10 ` Peter Korsgaard
2012-02-08 16:22 ` [Buildroot] [PATCH 5 of 5 v6] dependencies: build a host-tar if no suitable tar can be found Thomas De Schampheleire
2012-02-09 22:18 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k43v4szv.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox