From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] libarchive package added
Date: Wed, 02 Sep 2009 10:02:12 +0200 [thread overview]
Message-ID: <87k50hpyez.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <20090901225917.GE9410@buzzloop.caiaq.de> (Daniel Mack's message of "Wed\, 2 Sep 2009 00\:59\:17 +0200")
>>>>> "Daniel" == Daniel Mack <daniel@caiaq.de> writes:
Hi,
>> Ok, we don't normally do this per-package - So I'm hessitant to add
>> it here. Other than that, it looks fine.
Daniel> Hmm, maybe that should be an option to more packages then, and
Daniel> it could be added on demand, eg. whenever someone needs that.
I think adding so many configuration options for something like that
will just confuse people / complicate testing too much. Using
BR2_ROOTFS_POST_BUILD_SCRIPT for this seems like a nicer (and more
flexible) solution to me.
Daniel> But I understand that you're hessitant, so drop that part if you like,
Daniel> and we remove the installed files later from our postbuild script. No
Daniel> problem :)
Ok, added without that part. Notice that libarchive needs wchar support:
libarchive/archive_entry.c: In function 'aes_get_wcs':
libarchive/archive_entry.c:234: error: implicit declaration of function 'mbstowcs'
I've fixed the kconfig to ensure that.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2009-09-02 8:02 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-25 14:04 [Buildroot] [PATCH] libarchive package added Daniel Mack
2009-08-31 20:48 ` Daniel Mack
2009-09-01 14:52 ` Peter Korsgaard
2009-09-01 15:07 ` Daniel Mack
2009-09-01 15:16 ` Peter Korsgaard
2009-09-01 22:59 ` Daniel Mack
2009-09-02 8:02 ` Peter Korsgaard [this message]
2009-09-02 9:57 ` Daniel Mack
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k50hpyez.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox