Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] avr32 patches vs. x86 breakage
Date: Fri, 21 Mar 2008 08:45:42 +0100	[thread overview]
Message-ID: <87k5jw34gp.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1206079232.2562.60.camel@nigel-x60> (Nigel Kukard's message of "Fri\, 21 Mar 2008 06\:00\:32 +0000")

>>>>> "Nigel" == Nigel Kukard <nkukard@lbsd.net> writes:

Hi,

 Nigel> Hi Guys,
 Nigel> Will this proposal to fix the problem work ...

 Nigel> - Make a dir under arch-avr32, for gcc-x.y.z

 Nigel> - Add a make file to set something like
 Nigel> BOARD_EXTRA_PATCH_PATH=target/device/arch-avr32  this will be set if the
 Nigel> board is AVR32 based 

 Nigel> - In GCC / binutils/ uclibc and where ever else avr32 patches are
 Nigel> applied, we can tst if BOARD_EXTRA_PATCH_PATH is available. If it is to
 Nigel> add those patches into the patch set being applied. This should be
 Nigel> simplistic as we know the version for instance GCC_VERSION, we'd just
 Nigel> have to test the path exists and do something like    \*.patch
 Nigel> $(MORE_PATCHES)  , where we set a few lines up.  MORE_PATCHES=
 Nigel> $(BOARD_EXTRA_PATCH_PATH)/gcc-$(GCC_VERSION)

As discussed on IRC, I think its cleaner if everything related to a
package is located under the package/<package>/ dir.

The real problem is that apparent quality issues of some of the arch
specific patches.

If possible, I would prefer if all archs would use the same sources
(so apply the same patches for all archs) as the patches then get a
lot more testing - E.G. you might otherwise not notice if a patch for
some obscure arch no longer applies because you bumped the version of
a package.

But that doesn't seem realistic with the current patches, so I instead
suggest we split up patches in generic and arch specific. The generic
ones gets applied to all archs, and only the arch specific ones for
the selected arch.

The easiest setup is probably to use the naming convention:

 - package-version-*.patch for generic stuff
 - arch-package-version-*.patch for arch specific stuff

What do you think?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2008-03-21  7:45 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-03-21  6:00 [Buildroot] avr32 patches vs. x86 breakage Nigel Kukard
2008-03-21  7:45 ` Peter Korsgaard [this message]
     [not found]   ` <1206086506.2562.64.camel@nigel-x60>
2008-03-21  8:18     ` Peter Korsgaard
2008-03-21  8:38       ` Nigel Kukard
2008-03-21  8:52   ` Bernhard Fischer
2008-03-21  9:12     ` Nigel Kukard
2008-03-21  9:30       ` Peter Korsgaard
2008-03-25  8:55         ` Ulf Samuelsson
     [not found]     ` <87hcf01m0r.fsf@macbook.be.48ers.dk>
2008-03-21  9:32       ` Peter Korsgaard
2008-03-21 11:36         ` John Voltz
2008-03-21 12:11           ` Bernhard Fischer
2008-03-21 12:47             ` John Voltz
2008-03-25  8:50   ` Ulf Samuelsson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k5jw34gp.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox