Re: [Buildroot] [PATCH] package/libcamera: force-disable qcam for now

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Quentin" == Quentin Schulz <foss+buildroot@0leil.net> writes:

 > From: Quentin Schulz <quentin.schulz@cherry.de>
 > qcam is based on Qt6 since commit 71aa3ceec30b ("apps: qcam: Port to Qt
 > 6") which is part of the v0.3.1 release.

 > qcam being enabled when BR2_PACKAGE_QT5BASE_WIDGETS symbol is defined
 > breaks the build as it's missing the qt6 dependencies.

 > The migration to Qt 6 for the Buildroot package isn't straightforward
 > though as we're hitting a meson bug[1].

 > For now, let's just always disable qcam until we can get everything
 > fixed and migrated properly.

 > [1] https://github.com/mesonbuild/meson/issues/13018

 > Fixes: 72757d111a5d ("package/libcamera: bump to version 0.3.2")
 > Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>

Committed after adding an autobuilder reference, thanks.

> ---
 > This is suboptimal solution to unbreaking Buildroot builds of libcamera
 > when Qt5 Widgets are enabled but that should do for Buildroot 2025.02
 > release.

 > We should ideally work on adding proper support for qcam in a later
 > commit, once the issue reported in
 > https://github.com/mesonbuild/meson/issues/13018 is either fixed or
 > worked around in Buildroot.

 > FWIW, I went as far as:

 > ```
 > ifeq ($(BR2_PACKAGE_QT6BASE_WIDGETS)$(BR2_PACKAGE_QT6_OPENGL),yy)
 > LIBCAMERA_CONF_OPTS += -Dqcam=enabled
 > LIBCAMERA_DEPENDENCIES += qt6base
 > else
 > LIBCAMERA_CONF_OPTS += -Dqcam=disabled
 > endif
 > ```

 > as Qt6 OpenGL module seems required now. Additionally, the Qt6 tools
 > dependency is doing nothing so it can be removed. It actually never did
 > anything but turn a check from meson from red to green in the configure
 > step, the binaries with and without Qt tools (qt5 or qt6) were always
 > identical to the bit.

Thanks for investigating!


 > There are also a number of other changes we should be making to the
 > recipe as libcamera is extended without knobs if libdrm, libsdl2,
 > libjpeg, libdw and/or libunwind are provided. So we should add those to
 > LIBCAMERA_DEPENDENCIES if they are part of the build, to make builds
 > reproducible.

Will you send patches for that as well?

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot