Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle <arnout@mind.be>
Cc: Julien Olivain <ju.o@free.fr>, Peter Seiderer <ps.report@gmx.net>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org, Romain Naour <romain.naour@gmail.com>,
	"Yann E. MORIN" <yann.morin.1998@free.fr>
Subject: Re: [Buildroot] [RFC v1] package/coreutils: needs toolchain headers >= 5.6 (32-bit system with 64-bit time_t)
Date: Sun, 04 Jun 2023 13:20:30 +0200	[thread overview]
Message-ID: <87legza2yp.fsf@48ers.dk> (raw)
In-Reply-To: <57ffa030-89c0-cb57-b7b2-cc8ffa452d01@mind.be> (Arnout Vandecappelle's message of "Sat, 3 Jun 2023 22:41:25 +0200")

>>>>> "Arnout" == Arnout Vandecappelle <arnout@mind.be> writes:

Hi,

 >  Because of all this complexity, I think it's better to introduce
 >  something like BR2_TOOLCHAIN_HAS_TIME_T_64 that encodes those
 > conditions. It would be a blind symbol that defaults y for 64-bit
 > architectures and is selected by the respective arch or toolchain
 > symbols. It's a bit complicated that way, but gives us most
 > flexibility to get all the conditions right. For instance, in external
 > toolchains it would only be selected if glibc is sufficiently recent.

 >  Therefore, I've marked this patch as Changes Requested. But I also
 >  added the other matinainters in Cc because they may have different
 > opinions.

No, I agree - Nice summary!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2023-06-04 11:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-10 20:24 [Buildroot] [RFC v1] package/coreutils: needs toolchain headers >= 5.6 (32-bit system with 64-bit time_t) Peter Seiderer
2023-06-03 20:41 ` Arnout Vandecappelle via buildroot
2023-06-04 11:20   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87legza2yp.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=arnout@mind.be \
    --cc=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    --cc=ps.report@gmx.net \
    --cc=romain.naour@gmail.com \
    --cc=thomas.petazzoni@bootlin.com \
    --cc=yann.morin.1998@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox