From: Peter Korsgaard <peter@korsgaard.com>
To: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
Cc: "André Zwing" <nerv@dawncrow.de>,
"Fabrice Fontaine" <fontaine.fabrice@gmail.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/wine: needs NPTL
Date: Thu, 11 Aug 2022 13:50:55 +0200 [thread overview]
Message-ID: <87lervknhc.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20220720223818.1854d156@windsurf> (Thomas Petazzoni via buildroot's message of "Wed, 20 Jul 2022 22:38:18 +0200")
>>>>> "Thomas" == Thomas Petazzoni via buildroot <buildroot@buildroot.org> writes:
> On Wed, 15 Jun 2022 22:16:22 +0200
> Fabrice Fontaine <fontaine.fabrice@gmail.com> wrote:
>> wine unconditionally uses pthread_attr_setstack resulting in the
>> following build failure without NPTL:
>>
>> /home/buildroot/autobuild/instance-3/output-1/host/lib/gcc/i586-buildroot-linux-uclibc/11.3.0/../../../../i586-buildroot-linux-uclibc/bin/ld:
>> dlls/ntdll/unix/thread.o: in function `NtCreateThreadEx':
>> thread.c:(.text+0x61b): undefined reference to `pthread_attr_setstack'
>>
>> Fixes:
>> - http://autobuild.buildroot.org/results/a866d65cda97845a8c829acad2c057bab00cde08
>>
>> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
>> ---
>> package/wine/Config.in | 6 ++++--
>> 1 file changed, 4 insertions(+), 2 deletions(-)
> The pthread_attr_setstack() has been around for a while in Wine, so I
> was wondering why we're only seeing this issue now. Turns out that Wine
> depends on BR2_i386, and until the relatively recent move to fully
> random configurations, we never tested an i386 toolchain that has
> linuxthreads suport instead of NPTL.
> Therefore: applied, thanks!
Committed to 2022.05.x and 2022.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2022-08-11 11:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-15 20:16 [Buildroot] [PATCH 1/1] package/wine: needs NPTL Fabrice Fontaine
2022-07-20 20:38 ` Thomas Petazzoni via buildroot
2022-08-11 11:50 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lervknhc.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=fontaine.fabrice@gmail.com \
--cc=nerv@dawncrow.de \
--cc=thomas.petazzoni@bootlin.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox