From: Peter Korsgaard <peter@korsgaard.com>
To: Giulio Benetti <giulio.benetti@benettiengineering.com>
Cc: samuel@sholland.org, buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 2/2] configs/nezha_defconfig: new defconfig
Date: Fri, 05 Nov 2021 14:35:19 +0100 [thread overview]
Message-ID: <87lf22iv3c.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <9DC7B415-F1A7-4D59-968C-EDD367DD2C16@benettiengineering.com> (Giulio Benetti's message of "Fri, 5 Nov 2021 14:28:46 +0100")
>>>>> "Giulio" == Giulio Benetti <giulio.benetti@benettiengineering.com> writes:
Hi,
>> +image sdcard.img {
>> + hdimage {
>> + }
>> +
>> + partition boot0-1 {
>> + in-partition-table = "no"
>> + image = "boot0_sdcard_sun20iw1p1.bin"
>> + offset = 8192
> Can you please use 8K here ^^^
>> + }
>> +
>> + partition boot0-2 {
>> + in-partition-table = "no"
>> + image = "boot0_sdcard_sun20iw1p1.bin"
>> + offset = 131072
> 128K here etc.
> I find it to be easier to read.
Ok. The "documentation" actually lists this in 512b sectors, but I don't
think genimage has something nice to handle this:
https://linux-sunxi.org/Allwinner_Nezha
> I would go for changing every .cfg file in Buildroot and submit a
> patchset for this to improve readibility. What do you all think about
> this?
Fine by me.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2021-11-05 13:35 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-05 12:38 [Buildroot] [PATCH 1/2] boot/sun20i-d1-spl: new package Peter Korsgaard
2021-11-05 12:38 ` [Buildroot] [PATCH 2/2] configs/nezha_defconfig: new defconfig Peter Korsgaard
2021-11-05 13:10 ` Thomas Petazzoni
2021-11-05 13:26 ` Peter Korsgaard
2021-11-05 13:28 ` Giulio Benetti
2021-11-05 13:35 ` Peter Korsgaard [this message]
2021-11-05 13:52 ` Giulio Benetti
2021-11-05 14:30 ` Peter Korsgaard
2021-11-07 0:49 ` Giulio Benetti
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lf22iv3c.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=samuel@sholland.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox