From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/3] package/mosquitto: allow to build as static lib
Date: Sat, 03 Aug 2019 13:13:45 +0200 [thread overview]
Message-ID: <87lfwaec2e.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190803093858.144555-2-titouan.christophe@railnova.eu> (Titouan Christophe's message of "Sat, 3 Aug 2019 11:38:56 +0200")
>>>>> "Titouan" == Titouan Christophe <titouan.christophe@railnova.eu> writes:
> Since version 1.5, it is possible to build mosquitto as a static lib.
> However, the broker still needs a toolchain with support for shared libraries,
> because it contains code to dynamically load modules at runtime. This
> code makes use of dlfcn.h, which is only available for dylib enabled
> systems.
> Signed-off-by: Titouan Christophe <titouan.christophe@railnova.eu>
> ---
> package/mosquitto/Config.in | 9 +++------
> package/mosquitto/mosquitto.mk | 12 ++++++++++++
> 2 files changed, 15 insertions(+), 6 deletions(-)
> diff --git a/package/mosquitto/Config.in b/package/mosquitto/Config.in
> index c7373d9a84..8f2561c2d8 100644
> --- a/package/mosquitto/Config.in
> +++ b/package/mosquitto/Config.in
> @@ -1,6 +1,5 @@
> config BR2_PACKAGE_MOSQUITTO
> bool "mosquitto"
> - depends on !BR2_STATIC_LIBS # builds .so
> help
> Mosquitto is an open source message broker that implements
> the MQ Telemetry Transport protocol versions 3.1 and
> @@ -16,12 +15,10 @@ config BR2_PACKAGE_MOSQUITTO_BROKER
> bool "install the mosquitto broker"
> default y
> depends on BR2_USE_MMU # fork()
> + depends on !BR2_STATIC_LIBS # include <dlfcn.h>
> depends on BR2_PACKAGE_MOSQUITTO
> help
> Build and install the mosquitto broker onto target.
> -comment "mosquitto broker needs a system with MMU"
> - depends on BR2_PACKAGE_MOSQUITTO && !BR2_USE_MMU
> -
> -comment "mosquitto needs a toolchain w/ dynamic library"
> - depends on BR2_STATIC_LIBS
> +comment "mosquitto broker needs a system with MMU; toolchain w/ dynamic library"
> + depends on BR2_PACKAGE_MOSQUITTO && (!BR2_USE_MMU || BR2_STATIC_LIBS)
Not your fault, but this message should not mention MMU (as the user
cannot change it) and only be displayed if mosquitto && mmu && static.
Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-08-03 11:13 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-03 9:38 [Buildroot] [PATCH v2 0/3] Update package mosquitto Titouan Christophe
2019-08-03 9:38 ` [Buildroot] [PATCH 1/3] package/mosquitto: allow to build as static lib Titouan Christophe
2019-08-03 11:13 ` Peter Korsgaard [this message]
2019-08-03 9:38 ` [Buildroot] [PATCH 2/3] package/mosquitto: extend systemd integration Titouan Christophe
2019-08-03 11:13 ` Peter Korsgaard
2019-08-03 9:38 ` [Buildroot] [PATCH 3/3] package/mosquitto: update help text in Config.in Titouan Christophe
2019-08-03 11:14 ` Peter Korsgaard
-- strict thread matches above, loose matches on Subject: below --
2019-07-18 10:06 [Buildroot] [PATCH 0/3] Update package mosquitto Titouan Christophe
2019-07-18 10:06 ` [Buildroot] [PATCH 1/3] package/mosquitto: allow to build as static lib Titouan Christophe
2019-08-01 10:23 ` Peter Korsgaard
2019-08-01 10:41 ` Peter Korsgaard
2019-08-01 17:09 ` Titouan Christophe
2019-08-01 17:25 ` Peter Korsgaard
2019-08-02 13:18 ` Titouan Christophe
2019-08-02 15:58 ` Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfwaec2e.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox