From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] redis: use BR2_TOOLCHAIN_HAS_LIBATOMIC
Date: Mon, 28 Mar 2016 22:40:07 +0200 [thread overview]
Message-ID: <87lh528hg8.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1459174261-25242-1-git-send-email-gustavo@zacarias.com.ar> (Gustavo Zacarias's message of "Mon, 28 Mar 2016 11:11:01 -0300")
>>>>> "Gustavo" == Gustavo Zacarias <gustavo@zacarias.com.ar> writes:
> It uses __atomic_fetch_add_4 so libatomic must be pulled in if
> necessary. Fixes:
> http://autobuild.buildroot.net/results/dfd/dfdfd77463b0ddd7016202372afcad7fb6fc9ce4/
> # Redis doesn't support DESTDIR (yet, see
> # https://github.com/antirez/redis/pull/609). We set PREFIX
> # instead.
> -REDIS_BUILDOPTS = $(TARGET_CONFIGURE_OPTS) \
> +REDIS_BUILDOPTS = \
> + CC="$(TARGET_CC)" \
> + CFLAGS="$(TARGET_CFLAGS)" \
> + LDFLAGS="$(TARGET_LDFLAGS) $(REDIS_LIBATOMIC)" \
> PREFIX=$(TARGET_DIR)/usr MALLOC=libc \
On second thought, I prefer to keep this as TARGET_CONFIGURE_OPTS
instead of explicitly passing CC / CFLAGS, so I've changed that while
committing.
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2016-03-28 20:40 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-03-28 14:11 [Buildroot] [PATCH] redis: use BR2_TOOLCHAIN_HAS_LIBATOMIC Gustavo Zacarias
2016-03-28 20:36 ` Peter Korsgaard
2016-03-28 20:40 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lh528hg8.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox