From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] ti-utils: bump version and clean up
Date: Tue, 09 Aug 2011 13:28:54 +0200 [thread overview]
Message-ID: <87liv2kemh.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <4E3F8BE5.1030607@visionsystems.de> (Yegor Yefremov's message of "Mon, 08 Aug 2011 09:10:29 +0200")
>>>>> "Yegor" == Yegor Yefremov <yegor_sub1@visionsystems.de> writes:
Yegor> Signed-off-by: Yegor Yefremov <yegorslists@googlemail.com>
Thanks, committed with some fixes (see below)
Yegor> -TI_UTILS_VERSION = fbceab8f228cff80fd29b830bb85a188c69def08
Yegor> +TI_UTILS_VERSION = 06dbdb2727354b5f3ad7c723897f40051fddee49
Yegor> TI_UTILS_SITE = git://github.com/gxk/ti-utils.git
Yegor> TI_UTILS_DEPENDENCIES = libnl
Yegor> -
Yegor> +
You have a lot of whitespace damage where you have added a space at the
beginning of each line.
Yegor> define TI_UTILS_BUILD_CMDS
Yegor> - $(MAKE1) NFSROOT="$(STAGING_DIR)" CC="$(TARGET_CC) $(TARGET_CFLAGS) $(TARGET_LDFLAGS)" \
Yegor> - -C $(@D) all
Yegor> + $(MAKE1) NFSROOT="$(STAGING_DIR)" \
Yegor> + CC="$(TARGET_CC) $(TARGET_CFLAGS) \
Yegor> + $(TARGET_LDFLAGS)" -C $(@D) all
I prefer to indent the followup lines (like you do below) to make it
clear that it is part of the previous statement.
Yegor> endef
Yegor> -
Yegor> +
Yegor> define TI_UTILS_INSTALL_TARGET_CMDS
Yegor> - $(INSTALL) -m 0755 $(@D)/calibrator \
Yegor> - $(TARGET_DIR)/usr/bin/calibrator
Yegor> - $(INSTALL) -m 0755 $(@D)/scripts/go.sh \
Yegor> - $(TARGET_DIR)/usr/bin/go.sh
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/scripts
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x
Yegor> + mkdir -p $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x
You can use install -D instead of these explicit mkdirs.
Yegor> +
Yegor> + $(INSTALL) -m 0755 $(@D)/calibrator \
Yegor> + $(TARGET_DIR)/usr/bin/calibrator
Yegor> + $(INSTALL) -m 0755 $(@D)/scripts/go.sh \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/scripts/go.sh
Yegor> +
Please keep lines < 80 chars.
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/RFMD_S_3.5.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/RFMD_S_3.5.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_D_1.0.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_D_1.0.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_D_1.7.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_D_1.7.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_S_2.5.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_S_2.5.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/127x/TQS_S_2.6.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/127x/TQS_S_2.6.ini
Yegor> +
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/RFMD_S_3.5.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/RFMD_S_3.5.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_D_1.0.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_D_1.0.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_D_1.7.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_D_1.7.ini
Yegor> + $(INSTALL) -m 0644 $(@D)/ini_files/128x/TQS_S_2.6.ini \
Yegor> + $(TARGET_DIR)/usr/share/ti-utils/ini_files/128x/TQS_S_2.6.ini
Instead of all this we can just do:
cp -r $(@D)/ini_files $(TARGET_DIR)/usr/share/ti-utils
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2011-08-09 11:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-08-08 7:10 [Buildroot] [PATCH] ti-utils: bump version and clean up Yegor Yefremov
2011-08-09 11:28 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87liv2kemh.fsf@macbook.be.48ers.dk \
--to=jacmet@uclibc.org \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox