Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Julien Olivain via buildroot <buildroot@buildroot.org>
Cc: Julien Olivain <ju.o@free.fr>,
	 Francois Perrad <francois.perrad.86@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/perl: apply perl-cross patch only on target perl
Date: Mon, 31 Aug 2026 22:40:17 +0200	[thread overview]
Message-ID: <87mru2gh1q.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260831194910.260600-1-ju.o@free.fr> (Julien Olivain via buildroot's message of "Mon, 31 Aug 2026 21:49:10 +0200")

>>>>> "Julien" == Julien Olivain via buildroot <buildroot@buildroot.org> writes:

 > Buildroot commit [1] (package/perl: fix build issue with musl)
 > introduced a patch that is meant to be applied on top of perl-cross,
 > which is extracted on top of perl only in the target variant.

 > Since the patch was introduced as a normal package patch, the Buildroot
 > infra is trying to always apply it, even for the host package variant.
 > Since perl-cross is not extracted for the host variant, some patched
 > files are missing. In that case, the host-perl is failing with error:

 >>>> host-perl 5.42.3 Patching
 >     Applying 0001-configure-keep-_GNU_SOURCE-in-build-flags.patch using patch:
 >     can't find file to patch at input line 46

 > This commit fixes the issue by moving the package patch in a dedicated
 > "perl-cross" subdirectory, to make sure it will no longer be applied by
 > the infra. We apply the patch only for the target package variant using
 > a _POST_PATCH_HOOKS hook.

 > Fixes:
 > - [1]
 > - https://gitlab.com/buildroot.org/buildroot/-/jobs/16185948610 (TestPerlXMLLibXML)
 > - ...and few other tests requiring host-perl

 > [1] https://gitlab.com/buildroot.org/buildroot/-/commit/d950fff290b1318fd72c7f09fedbd1b87b96155f

 > Signed-off-by: Julien Olivain <ju.o@free.fr>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2026-08-31 20:40 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-31 19:49 [Buildroot] [PATCH 1/1] package/perl: apply perl-cross patch only on target perl Julien Olivain via buildroot
2026-08-31 20:40 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mru2gh1q.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=francois.perrad.86@gmail.com \
    --cc=ju.o@free.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox