[Buildroot] [PATCH 1/1] package/libvirt: fix dependency of lxc support

[Buildroot] [PATCH 1/1] package/libvirt: fix dependency of lxc support

[Bernd Kuhls]

Buildroot commit ed12e2fbed3d4298ebff9da54fe56b91fa75c41e in 2021 added
BR2_PACKAGE_LIBVIRT_LXC which selects BR2_PACKAGE_LXC but did not add
the dependency !BR2_TOOLCHAIN_USES_UCLIBC which was added to lxc in
2019 by buildroot commit 63aad8a53e33e3fae4793e05662f47637e9e9bfc
causing Kconfig warnings:

WARNING: unmet direct dependencies detected for BR2_PACKAGE_LXC
  Depends on [n]: BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y]
    && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]
    && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y]
  Selected by [y]:
  - BR2_PACKAGE_LIBVIRT_LXC [=y] && BR2_PACKAGE_LIBVIRT [=y]
      && BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]

Signed-off-by: Bernd Kuhls <bernd@kuhls.net>
---
 package/libvirt/Config.in | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
index 5664f69dd8..0f73128d09 100644
--- a/package/libvirt/Config.in
+++ b/package/libvirt/Config.in
@@ -89,12 +89,14 @@ comment "qemu needs a toolchain with gcc >= 8"
 config BR2_PACKAGE_LIBVIRT_LXC
 	bool "lxc"
 	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # lxc
+	depends on !BR2_TOOLCHAIN_USES_UCLIBC # lxc
 	select BR2_PACKAGE_LXC
 	help
 	  Linux Container support
 
-comment "lxc needs a toolchain w/ gcc >= 4.7"
-	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
+comment "lxc needs a glibc or musl toolchain w/ gcc >= 4.7"
+	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 \
+		|| BR2_TOOLCHAIN_USES_UCLIBC
 
 endif
 
-- 
2.47.3

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvirt: fix dependency of lxc support

[Peter Korsgaard]

>>>>> "Bernd" == Bernd Kuhls <bernd@kuhls.net> writes:

 > Buildroot commit ed12e2fbed3d4298ebff9da54fe56b91fa75c41e in 2021 added
 > BR2_PACKAGE_LIBVIRT_LXC which selects BR2_PACKAGE_LXC but did not add
 > the dependency !BR2_TOOLCHAIN_USES_UCLIBC which was added to lxc in
 > 2019 by buildroot commit 63aad8a53e33e3fae4793e05662f47637e9e9bfc
 > causing Kconfig warnings:

 > WARNING: unmet direct dependencies detected for BR2_PACKAGE_LXC
 >   Depends on [n]: BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y]
 >     && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]
 >     && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y]
 >   Selected by [y]:
 >   - BR2_PACKAGE_LIBVIRT_LXC [=y] && BR2_PACKAGE_LIBVIRT [=y]
 >       && BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]

 > Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

Re: [Buildroot] [PATCH 1/1] package/libvirt: fix dependency of lxc support

[Thomas Perale via buildroot]

In reply of:
> Buildroot commit ed12e2fbed3d4298ebff9da54fe56b91fa75c41e in 2021 added
> BR2_PACKAGE_LIBVIRT_LXC which selects BR2_PACKAGE_LXC but did not add
> the dependency !BR2_TOOLCHAIN_USES_UCLIBC which was added to lxc in
> 2019 by buildroot commit 63aad8a53e33e3fae4793e05662f47637e9e9bfc
> causing Kconfig warnings:
> 
> WARNING: unmet direct dependencies detected for BR2_PACKAGE_LXC
>   Depends on [n]: BR2_TOOLCHAIN_HAS_THREADS [=y] && BR2_USE_MMU [=y]
>     && !BR2_STATIC_LIBS [=n] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]
>     && BR2_TOOLCHAIN_HEADERS_AT_LEAST_3_0 [=y] && !BR2_TOOLCHAIN_USES_UCLIBC [=y]
>   Selected by [y]:
>   - BR2_PACKAGE_LIBVIRT_LXC [=y] && BR2_PACKAGE_LIBVIRT [=y]
>       && BR2_PACKAGE_LIBVIRT_DAEMON [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 [=y]
> 
> Signed-off-by: Bernd Kuhls <bernd@kuhls.net>

Applied to 2025.02.x & 2025.11.x. Thanks

> ---
>  package/libvirt/Config.in | 6 ++++--
>  1 file changed, 4 insertions(+), 2 deletions(-)
> 
> diff --git a/package/libvirt/Config.in b/package/libvirt/Config.in
> index 5664f69dd8..0f73128d09 100644
> --- a/package/libvirt/Config.in
> +++ b/package/libvirt/Config.in
> @@ -89,12 +89,14 @@ comment "qemu needs a toolchain with gcc >= 8"
>  config BR2_PACKAGE_LIBVIRT_LXC
>  	bool "lxc"
>  	depends on BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 # lxc
> +	depends on !BR2_TOOLCHAIN_USES_UCLIBC # lxc
>  	select BR2_PACKAGE_LXC
>  	help
>  	  Linux Container support
>  
> -comment "lxc needs a toolchain w/ gcc >= 4.7"
> -	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7
> +comment "lxc needs a glibc or musl toolchain w/ gcc >= 4.7"
> +	depends on !BR2_TOOLCHAIN_GCC_AT_LEAST_4_7 \
> +		|| BR2_TOOLCHAIN_USES_UCLIBC
>  
>  endif
>  
> -- 
> 2.47.3
> 
> _______________________________________________
> buildroot mailing list
> buildroot@buildroot.org
> https://lists.buildroot.org/mailman/listinfo/buildroot
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot