Re: [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2

From: Peter Korsgaard <peter@korsgaard.com>
To: "Yann E. MORIN" <yann.morin.1998@free.fr>
Cc: Geoff Levand <geoff@infradead.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>,
	buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/flannel: Bump to version 0.25.2
Date: Thu, 30 May 2024 20:17:53 +0200	[thread overview]
Message-ID: <87mso7qi3y.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <ZldxjKMyzPIK1djL@landeda> (Yann E. MORIN's message of "Wed, 29 May 2024 20:18:52 +0200")

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Geoff, All,
 > On 2024-05-29 17:58 +0900, Geoff Levand spake thusly:
 >> On 5/29/24 15:30, Peter Korsgaard wrote:
 >> >>>>>> "Geoff" == Geoff Levand <geoff@infradead.org> writes:
 >> >  > -sha256
 >> >  > 8406a3b2b799344197c79f96e5b39ea7b6228f0bb2cb069b5f44dce684e29b9b
 >> >  > flannel-0.25.1-go2.tar.gz
 >> >  > +sha256
 >> >  > 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954
 >> >  > flannel-0.25.2-go2.tar.gz
 >> > Hmm, I get a different hash here?
 >> > ERROR: while checking hashes from package/flannel/flannel.hash
 >> > ERROR: flannel-0.25.2-go2.tar.gz has wrong sha256 hash:
 >> > ERROR: expected: 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954
 >> > ERROR: got     : e181a5e4233db47b0f03718ea801274c3a6024d235ead76e974f3df4f4183de1
 >> I see this in the build log;
 >> flannel-0.25.2-go2.tar.gz: OK (sha256:
 >> 565dedf012a358d87d6bb89a4b7118a4a7ab9a3aada9b9bf76349ca5e451d954)
 >> >>> flannel 0.25.2 Extracting
 >> Maybe there was some problem with your download of flannel-0.25.2-go2.tar.gz 

 > The issue has been identified:
 >   - we now require tar >= 1.35 (for reproducibility of tarballs)
 >   - we check whether the tar on the host system is suitable
 >   - if not, then we build our own host-tar, and use that

 > So we should always use a valid tar: either the system one, or our own.

 > However (there is always a "however"), the user can set TAR in their
 > environment, to instruct Buildroot to use that specific tar. For
 > example, it is possible to do:

 >     $ TAR=tar-1.35 make

 > So, when we check whether the host tar is suitable, we in fact check
 > that $(TAR) as provided by the user (and if not given, then we default
 > to looking 'tar' in PATH).

 > But we do not use $(TAR) from the download helper infrastructure, where
 > we only use 'tar'.

 > so, when the user has a system with an older tar in PATH, but provides a
 > TAR=tar-1.35 when building, then there is a discrepancy between the tar
 > we check, and the one we use.

 > Boom.

 > That's what happened to Peter.

Yes, sorry about the noise. Will get that issue fixed.

Committed, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot