From: Peter Korsgaard <peter@korsgaard.com>
To: Romain Naour <romain.naour@gmail.com>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH] package/busybox: disable sha1/sha256 hwaccel with x86 musl toolchains
Date: Mon, 05 Jun 2023 22:10:34 +0200 [thread overview]
Message-ID: <87mt1d656t.fsf@48ers.dk> (raw)
In-Reply-To: <20230502220451.3087471-1-romain.naour@gmail.com> (Romain Naour's message of "Wed, 3 May 2023 00:04:51 +0200")
>>>>> "Romain" == Romain Naour <romain.naour@gmail.com> writes:
> Buxybox's init segfault when built with x86 musl toolchain due to
> recent changes about sha1 and sha156 hwaccel support in Busybox 1.36.0.
> From Alpinelinux [1]:
> "main/busybox: disable sha hwaccel
> the flag check for this seems incorrect- it triggers sha_ni use when
> the instructions aren't available, but avx512vl/bw is - Elly on irc
> causes failures in github actions, which have avx512 but no sha_no"
> The flag check should be fixed upstream by commit [2].
> But init still crash with the latest 1_36_stable (with backported patch)
> and master branch...
> Disable sha hwaccel with x86 musl toolchains until the issue is fixed.
> Checked that qemu_x86_64_defconfig with musl for x86_64 for core2 boot
> as expected with sha hwaccel enabled.
> The same workaround has been applied to openembedded-core [3].
> [1]
> https://git.alpinelinux.org/aports/commit/main/busybox?id=ae2cfdf6f6da3dc46ee09d8ceafa26921f6e058e
> [2] https://git.busybox.net/busybox/commit/?id=bd76b75f72f717150b909e8c64edfda725cabe11
> [3]
> https://github.com/openembedded/openembedded-core/commit/22f639d61127f4b82a79008c5305e44e090a3680
> Fixes:
> https://gitlab.com/buildroot.org/toolchains-builder/-/jobs/4202276721
> Signed-off-by: Romain Naour <romain.naour@gmail.com>
Committed to 2023.02.x, thanks.
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
prev parent reply other threads:[~2023-06-05 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-02 22:04 [Buildroot] [PATCH] package/busybox: disable sha1/sha256 hwaccel with x86 musl toolchains Romain Naour
2023-05-07 13:03 ` Yann E. MORIN
2023-05-10 9:04 ` Romain Naour
2023-06-05 20:10 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt1d656t.fsf@48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=romain.naour@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox