Re: [Buildroot] [PATCH 2/2] package/go: explicitly set GOMODCACHE

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > Peter, All,
 > On 2023-01-16 11:50 +0100, Peter Korsgaard spake thusly:
 >> go mod vendor caches downloaded modules to the Go module cache, which
 >> defaults to $GOPATH/pkg/mod - But can be overridden with the GOMODCACHE
 >> environment variable:
 >> 
 >> https://go.dev/ref/mod#module-cache
 >> 
 >> So explicitly set GOMODCACHE= for reproducibility.
 >> 
 >> Signed-off-by: Peter Korsgaard <peter@korsgaard.com>

 > Applied to master, thanks, but see below...

 >> ---
 >> package/go/go.mk | 1 +
 >> 1 file changed, 1 insertion(+)
 >> 
 >> diff --git a/package/go/go.mk b/package/go/go.mk
 >> index c4f72d403c..c38ae0b99c 100644
 >> --- a/package/go/go.mk
 >> +++ b/package/go/go.mk
 >> @@ -26,6 +26,7 @@ HOST_GO_COMMON_ENV = \
 >> GOROOT="$(HOST_GO_ROOT)" \
 >> GOPATH="$(HOST_GO_GOPATH)" \
 >> GOCACHE="$(HOST_GO_TARGET_CACHE)" \
 >> +	GOMODCACHE="$(HOST_GO_GOPATH)/pkg/mod" \

 > HOST_GO_GOPATH is $(HOST_DIR)/share/go-path, however, with PPD, HOST_DIR
 > is per-package, so there will not besharing of the cache between two
 > packages, unless there is a build dependency between them (unlikely in
 > the go ecosystem).

 > If we wanted to really share the go cache(s), we need to hit somewhere
 > in $(BR2_DL_DIR), like we do for cargo, see 8450b7691870 (package/pkg-cargo:
 > move CARGO_HOME into DL_DIR).

 > Still, this patch guarantees that the current situation is reproducible,
 > and does not depend on the user's environment.

Yes, I know. As far as I can see this was already the case (on systems
where GOMODCACHE isn't set), and I wanted a "safe" fix we could backport
- But indeed, longer term we should probably put the go module cache in
DL_DIR like we recently did for the cargo cache.

 > Applied to master, thanks.

Thanks!

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot