Re: [Buildroot] [PATCH v4] package/gitlab-runner: new package

["Marcin Niestrój" <m.niestroj@grinn-global.com>]

Romain Naour <romain.naour@smile.fr> writes:

> From: Marcin Niestroj <m.niestroj@grinn-global.com>
>
> We rely on config.toml to be created manually during first boot as setup stage.
> Even with an empty config.toml file, the gitlab-runner needs gitlab
> registration token to register to a gitlab server.
>
> Use the 14.5.1 release since 14.5.2 and 14.6.0 triggers a build error [1]
> due a patch for GO < 1.17.
> (helpers/patches/issue_28732/syscall.go:11:2: undefined: syscall.Issue28732Fix)
>
> Tested:
> https://gitlab.com/kubu93/buildroot/-/pipelines/442604876
>
> [1] https://gitlab.com/gitlab-org/gitlab-runner/-/issues/28766
>
> Signed-off-by: Marcin Niestroj <m.niestroj@grinn-global.com>
> Signed-off-by: Romain Naour <romain.naour@smile.fr>
> Cc: Jérémy Rosen <jeremy.rosen@smile.fr>
> ---
> Note: We used the gitlab-runner for shell or python jobs.
> Jobs using docker images (images: in gitlab-ci.yml) is not tested.
>
> v4: update to 14.5.1
>     Remove config.toml handling from .mk.
>     We rely on config.toml to be created during first boot as setup stage.
>     Even with an empty config.toml file, the gitlab-runner needs gitlab
>     registration token to register to a gitlab server. (Marcin Niestroj)
>     Remove alias gitlab-ci-multi-runner.service (Marcin Niestroj),
>     gitlab-ci-multi-runner.service comme from Debian gitlab-runner systemd
>     service file.
>
> v3: Change daemon process to gitlab-runner user.
>     see as example: https://git.buildroot.net/buildroot/tree/package/tpm2-abrmd/S80tpm2-abrmd?h=2020.05-rc2#n31
>
> [Romain: Tested only using systemd init on aarch64 target emulated by Qemu]
> v2: add service file, config file, gitlab user.
>     add bash as runtime dependency.
>     Add git, curl, ca-certificate, tar runtime dependencies from on debian control file for gitlab-runner package.
>     Use gnu tar since we can expect tar options that are not supported by busybox tar implementation.
>     Enable SSL/TLS library with openssl needed at runtime.
>     Add me as "developer".
>
> test-pkg config:
> BR2_PACKAGE_GITLAB_RUNNER=y
> ---

Thanks Romain for updating and resending this patch! Looks fine to me as it is!

--
Regards,
Marcin Niestrój
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot