From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2/2] package/gerbera: add upstream patch to fix find_program with taglib-config
Date: Sun, 23 Jun 2019 22:56:01 +0200 [thread overview]
Message-ID: <87mui8aun2.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20190610212023.9483-3-joerg.krause@embedded.rocks> ("Jörg Krause"'s message of "Mon, 10 Jun 2019 23:20:23 +0200")
>>>>> "J?rg" == J?rg Krause <joerg.krause@embedded.rocks> writes:
> Add an from from upstream to fix linking Gerbera with taglib. The patch
> fixes the following issue:
> When cross-compiling CMakes `find_program()` will search for binaries on the
> host. This is typically correct, e.g. when search for compilers or shells.
> When cross-compiling, searching for `taglib-config` using `find_program` should
> not find the binary on the host, instead it should find the binary in the sysroot
> directory, as the host `taglib-config` will output the wrong host paths
> and libs, whereas the sysroot `taglib-config` will output the correct sysroot
> paths and libs.
> Therefore, use the `CMAKE_FIND_ROOT_PATH_MODE_PROGRAM` variable when
> cross-compiling. This variable controls whether the `CMAKE_FIND_ROOT_PATH`
> and `CMAKE_SYSROOT` are used by find_program().
> Signed-off-by: J?rg Krause <joerg.krause@embedded.rocks>
Committed to 2019.02.x and 2019.05.x, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2019-06-23 20:56 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-06-10 21:20 [Buildroot] [PATCH 0/2] Fix linking gerbera with taglib Jörg Krause
2019-06-10 21:20 ` [Buildroot] [PATCH 1/2] package/taglib: add upstream patch to fix taglib-config Jörg Krause
2019-06-10 22:25 ` Arnout Vandecappelle
2019-06-16 13:24 ` Jörg Krause
2019-06-18 9:31 ` Arnout Vandecappelle
2019-06-23 21:00 ` Peter Korsgaard
2019-06-10 21:20 ` [Buildroot] [PATCH 2/2] package/gerbera: add upstream patch to fix find_program with taglib-config Jörg Krause
2019-06-10 22:33 ` Arnout Vandecappelle
2019-06-11 15:08 ` Thomas Petazzoni
2019-06-23 20:56 ` Peter Korsgaard [this message]
2019-06-10 22:20 ` [Buildroot] [PATCH 0/2] Fix linking gerbera with taglib Arnout Vandecappelle
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mui8aun2.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox