From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH v3 3/4] package/binutils: Cortex-M targets require version <2.29
Date: Fri, 01 Jun 2018 16:36:02 +0200 [thread overview]
Message-ID: <87muwezi99.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1527772887-31616-3-git-send-email-christophe.priouzeau@st.com> (Christophe PRIOUZEAU's message of "Thu, 31 May 2018 13:21:33 +0000")
>>>>> "Christophe" == Christophe PRIOUZEAU <christophe.priouzeau@st.com> writes:
> From: Laurent GONZALEZ <br22@gezedo.com>
> binutils 2.29 changed the implementation of adr pseudo instruction
> it breaks linux kernel and impacts Cortex-M targets (eg. stm32)
> Signed-off-by: Laurent GONZALEZ <br22@gezedo.com>
> Signed-off-by: Christophe Priouzeau <christophe.priouzeau@st.com>
> ---
> package/binutils/Config.in.host | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/package/binutils/Config.in.host b/package/binutils/Config.in.host
> index 03b2281..9a4caad 100644
> --- a/package/binutils/Config.in.host
> +++ b/package/binutils/Config.in.host
> @@ -2,8 +2,9 @@ comment "Binutils Options"
> choice
> prompt "Binutils Version"
> - default BR2_BINUTILS_VERSION_2_29_X if !BR2_arc
> - default BR2_BINUTILS_VERSION_ARC if BR2_arc
> + default BR2_BINUTILS_VERSION_2_28_X if BR2_ARM_CPU_ARMV7M
> + default BR2_BINUTILS_VERSION_2_29_X if !BR2_arc && !BR2_ARM_CPU_ARMV7M
> + default BR2_BINUTILS_VERSION_ARC if BR2_arc && !BR2_ARM_CPU_ARMV7M
kconfig will use the first available default line, so it is enough to
simply add:
default BR2_BINUTILS_VERSION_2_28_X if BR2_ARM_CPU_ARMV7M
In front of the others. Committed with that fixed, thanks.
--
Bye, Peter Korsgaard
next prev parent reply other threads:[~2018-06-01 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-31 13:21 [Buildroot] [PATCH v3 1/4] Revert "configs/stm32f429: force usage of binutils 2.28.x" Christophe PRIOUZEAU
2018-05-31 13:21 ` [Buildroot] [PATCH v3 2/4] Revert "configs/stm32f469: " Christophe PRIOUZEAU
2018-06-01 14:42 ` Peter Korsgaard
2018-05-31 13:21 ` [Buildroot] [PATCH v3 3/4] package/binutils: Cortex-M targets require version <2.29 Christophe PRIOUZEAU
2018-06-01 14:36 ` Peter Korsgaard [this message]
2018-06-01 15:42 ` Yann E. MORIN
2018-06-01 17:17 ` Peter Korsgaard
2018-05-31 13:21 ` [Buildroot] [PATCH v3 4/4] linux: config.in: add comment for Arm Cortex-M Christophe PRIOUZEAU
2018-06-01 14:39 ` Peter Korsgaard
2018-06-01 15:39 ` Yann E. MORIN
2018-06-01 17:21 ` Yann E. MORIN
2018-06-01 14:41 ` [Buildroot] [PATCH v3 1/4] Revert "configs/stm32f429: force usage of binutils 2.28.x" Peter Korsgaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87muwezi99.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox