Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] mpv: fix X11 logic after bump to 0.25.0
Date: Mon, 08 May 2017 21:10:57 +0200	[thread overview]
Message-ID: <87mvannozi.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1494250371-13487-1-git-send-email-thomas.petazzoni@free-electrons.com> (Thomas Petazzoni's message of "Mon, 8 May 2017 15:32:51 +0200")

>>>>> "Thomas" == Thomas Petazzoni <thomas.petazzoni@free-electrons.com> writes:

 > Between 0.24.0 and 0.25.0, mpv has changed its logic around the
 > detection/usage of X11 (in upstream commit
 > https://github.com/mpv-player/mpv/commit/927afa311d4a89b022305508acbf4e7325fe3928). Instead
 > of having fine grained option for x11, xext, xinerama, xscreensaver and
 > xrandr, mpv now requires all five libraries to be available in order to
 > enable X.org support.

 > Therefore, this commit adjusts the mpv packaging so that:

 >  1. All necessary X11 libraries are selected if BR2_PACKAGE_XORG7 is
 >     enabled. It would indeed be too cumbersome for the user to know that
 >     all of x11, xext, xinerama, xscreensaver and xrandr are necessary in
 >     order to have X.org support.

 >  2. mpv.mk is simplified by enabling X.org support when
 >     BR2_PACKAGE_XORG7 is enabled.

 > Fixes:

 > +# Base X11 support. Config.in ensures that if BR2_PACKAGE_XORG7 is
 > +# enabled, xlib_libX11, xlib_libXext, xlib_libXinerama,
 > +# xlib_libXrandr, xlib_libXScrnSaver.

It sounds like something is missing from this sentence. I've changed it
to:

'if BR2_PACKAGE_XORG7 is enabled, so is xlib_libX11, ..'

And committed, thanks.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2017-05-08 19:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-08 13:32 [Buildroot] [PATCH] mpv: fix X11 logic after bump to 0.25.0 Thomas Petazzoni
2017-05-08 19:10 ` Peter Korsgaard [this message]
2017-05-08 19:23   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mvannozi.fsf@dell.be.48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox