Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] dtc: broken for static builds
Date: Fri, 10 Jan 2014 23:00:45 +0100	[thread overview]
Message-ID: <87mwj37b02.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1389087873-40458-1-git-send-email-Vincent.Riera@imgtec.com> (Vicente Olivert Riera's message of "Tue, 7 Jan 2014 09:44:33 +0000")

>>>>> "Vicente" == Vicente Olivert Riera <Vincent.Riera@imgtec.com> writes:

 > dtc package has hardcoded shared lib link options in the Makefile, so it
 > will fail if you try to build it on a static lib environment.

 > Signed-off-by: Vicente Olivert Riera <Vincent.Riera@imgtec.com>
 > ---
 >  package/dtc/Config.in |    4 ++++
 >  1 files changed, 4 insertions(+), 0 deletions(-)

 > diff --git a/package/dtc/Config.in b/package/dtc/Config.in
 > index fac6ab2..aa9f2b1 100644
 > --- a/package/dtc/Config.in
 > +++ b/package/dtc/Config.in
 > @@ -1,5 +1,6 @@
 >  config BR2_PACKAGE_DTC
 >  	bool "dtc (libfdt)"
 > +	depends on !BR2_PREFER_STATIC_LIB
 >  	help
 >  	  The Device Tree Compiler, dtc, takes as input a device-tree in
 >  	  a given format and outputs a device-tree in another format.
 > @@ -9,6 +10,9 @@ config BR2_PACKAGE_DTC
 
 >  	  http://git.jdl.com/gitweb/?p=dtc.git  (no home page)
 
 > +comment "dtc needs a toolchain w/ dynamic library"
 > +	depends on BR2_PREFER_STATIC_LIB
 > +

Committed with the comment moved below the DTC_PROGRAMS suboption so
that one get indented correctly in menuconfig, thanks.

 >  if BR2_PACKAGE_DTC
 
 >  config BR2_PACKAGE_DTC_PROGRAMS
 > -- 
 > 1.7.1


 > _______________________________________________
 > buildroot mailing list
 > buildroot at busybox.net
 > http://lists.busybox.net/mailman/listinfo/buildroot


-- 
Bye, Peter Korsgaard

      parent reply	other threads:[~2014-01-10 22:00 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  9:44 [Buildroot] [PATCH] dtc: broken for static builds Vicente Olivert Riera
2014-01-09 20:14 ` Peter Korsgaard
2014-01-10 14:51   ` Vicente Olivert Riera
2014-01-10 21:59     ` Peter Korsgaard
2014-01-28 21:01       ` Thomas Petazzoni
2014-01-30  9:35         ` Vicente Olivert Riera
2014-02-02 21:12         ` Peter Korsgaard
2014-02-03  4:50           ` Baruch Siach
2014-01-10 22:00 ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwj37b02.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox