Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1/1] util-linux: enable sfdisk in configs
Date: Sun, 08 Sep 2013 22:11:14 +0200	[thread overview]
Message-ID: <87mwnnxee5.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <1376591640-3698-1-git-send-email-vsergeev@kumunetworks.com> (Ivan Sergeev's message of "Thu, 15 Aug 2013 11:34:00 -0700")

>>>>> "Ivan" == Ivan Sergeev <vsergeev@kumunetworks.com> writes:

 Ivan> Signed-off-by: Ivan Sergeev <vsergeev@kumunetworks.com>
 Ivan> ---
 Ivan>  package/util-linux/Config.in     | 5 +++++
 Ivan>  package/util-linux/util-linux.mk | 1 +
 Ivan>  2 files changed, 6 insertions(+)

 Ivan> diff --git a/package/util-linux/Config.in b/package/util-linux/Config.in
 Ivan> index e63814f..605e297 100644
 Ivan> --- a/package/util-linux/Config.in
 Ivan> +++ b/package/util-linux/Config.in
 Ivan> @@ -135,6 +135,11 @@ config BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS
 Ivan>  	help
 Ivan>  	  Scheduling utilities (chrt, ionice, taskset)
 
 Ivan> +config BR2_PACKAGE_UTIL_LINUX_SFDISK
 Ivan> +	bool "sfdisk"
 Ivan> +	help
 Ivan> +	  Partition table manipulator for Linux
 Ivan> +
 Ivan>  config BR2_PACKAGE_UTIL_LINUX_SWITCH_ROOT
 Ivan>  	bool "switch_root"
 Ivan>  	help
 Ivan> diff --git a/package/util-linux/util-linux.mk b/package/util-linux/util-linux.mk
 Ivan> index c6c8467..64112ba 100644
 Ivan> --- a/package/util-linux/util-linux.mk
 Ivan> +++ b/package/util-linux/util-linux.mk
 Ivan> @@ -68,6 +68,7 @@ UTIL_LINUX_CONF_OPT += \
 Ivan>  	$(if $(BR2_PACKAGE_UTIL_LINUX_RENAME),--enable-rename,--disable-rename) \
 Ivan>  	$(if $(BR2_PACKAGE_UTIL_LINUX_RESET),--enable-reset,--disable-reset) \
 Ivan>  	$(if $(BR2_PACKAGE_UTIL_LINUX_SCHEDUTILS),--enable-schedutils,--disable-schedutils) \
 Ivan> +	$(if $(BR2_PACKAGE_UTIL_LINUX_SFDISK),--enable-sfdisk,--disable-sfdisk) \

Ehh, I don't see any --enable-sfdisk / --disable-sfdisk configure
options?

 ./configure --help|grep -B2 sfdisk
  --enable-static-programs=LIST
                          link static the programs in LIST (comma-separated,
                          supported for losetup, mount, umount, fdisk, sfdisk,

Looking at fdisks/Makemodule.am I see sfdisk is always built (except for
on SPARC):

if !ARCH_SPARC

sbin_PROGRAMS += sfdisk
dist_man_MANS += fdisks/sfdisk.8
sfdisk_SOURCES = \
        fdisks/partname.c \
        fdisks/sfdisk.c \
        fdisks/common.h
sfdisk_LDADD = $(LDADD) libcommon.la

..

Before this patch we always built & installed sfdisk if
BR2_PACKAGE_UTIL_LINUX_BINARIES was enabled, and this patch doesn't
change anything.

-- 
Bye, Peter Korsgaard

  parent reply	other threads:[~2013-09-08 20:11 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-15 18:34 [Buildroot] [PATCH 1/1] util-linux: enable sfdisk in configs Ivan Sergeev
2013-09-02 16:19 ` Thomas Petazzoni
2013-09-08 20:11 ` Peter Korsgaard [this message]
2013-09-11 23:17   ` Ivan Sergeev
2013-09-14  5:51   ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwnnxee5.fsf@dell.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox