Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] New package: xinetd
Date: Mon, 28 May 2012 21:49:22 +0200	[thread overview]
Message-ID: <87mx4s6q7x.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1338230502-21663-1-git-send-email-danomimanchego123@gmail.com> (Danomi Manchego's message of "Mon, 28 May 2012 14:41:42 -0400")

>>>>> "Danomi" == Danomi Manchego <danomimanchego123@gmail.com> writes:

Hi,

 Danomi> Signed-off-by: Danomi Manchego <danomimanchego123@gmail.com>
 Danomi> ---
 Danomi>  package/Config.in                              |    1 +
 Danomi>  package/xinetd/Config.in                       |    8 +++
 Danomi>  package/xinetd/xinetd-2.3.15/001-ar.patch      |   66 ++++++++++++++++++++++++
 Danomi>  package/xinetd/xinetd-2.3.15/002-destdir.patch |   27 ++++++++++
 Danomi>  package/xinetd/xinetd-2.3.15/003-rpc_fix.patch |   19 +++++++

Please add a git-style header to each patch specifying the authorship
and a description of what they do + your signed-off-by.

 Danomi> +++ b/package/xinetd/xinetd.mk
 Danomi> @@ -0,0 +1,13 @@
 Danomi> +#############################################################
 Danomi> +#
 Danomi> +# xinetd
 Danomi> +#
 Danomi> +#############################################################
 Danomi> +XINETD_VERSION      = 2.3.15
 Danomi> +XINETD_SOURCE       = xinetd-$(XINETD_VERSION).tar.gz

Minor detail: This is the default value for _SOURCE, so you can skip
this line.

 Danomi> +XINETD_SITE         = http://www.xinetd.org
 Danomi> +XINETD_CONF_OPT     =
 Danomi> +XINETD_DEPENDENCIES =

No need to these two lines either.

 Danomi> +
 Danomi> +$(eval $(call AUTOTARGETS))
 Danomi> +

Please no trailing line.

Otherwise it looks good - Care to fix and resend?

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2012-05-28 19:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-28 18:41 [Buildroot] [PATCH] New package: xinetd Danomi Manchego
2012-05-28 19:49 ` Peter Korsgaard [this message]
2012-05-28 21:33   ` Danomi Manchego
2012-05-28 21:50     ` Peter Korsgaard
  -- strict thread matches above, loose matches on Subject: below --
2012-05-28 23:36 Danomi Manchego
2012-06-16 20:58 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mx4s6q7x.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox