Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH] zlib: fix installing when static-only
Date: Sun, 12 Dec 2010 09:11:18 +0100	[thread overview]
Message-ID: <87mxobl8bd.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <201012112252.52313.vapier@gentoo.org> (Mike Frysinger's message of "Sat, 11 Dec 2010 22:52:50 -0500")

>>>>> "Mike" == Mike Frysinger <vapier@gentoo.org> writes:

 Mike> On Saturday, December 11, 2010 16:53:14 Peter Korsgaard wrote:
 >> >>>>> "Mike" == Mike Frysinger writes:
 Mike> The switch from manual targets to using zlib's targets to fix shared
 Mike> building/installing doesn't work quite right as zlib itself doesn't
 Mike> handle static-only installs fully.
 >> 
 >> Ehh, that seems very similar to the zlib-1.2.5-fix-static-install.patch
 >> we already have?

 Mike> i dont know what you're referring to.  there are no patches currently:
 Mike> 	http://git.buildroot.net/buildroot/tree/package/zlib

Argh, you're right. I fixed it back in November, but apparently forgot
to git add the file:

commit ab2f5567c1ca67c7f761486495d3d42f2b7c8eff
Author: Peter Korsgaard <jacmet@sunsite.dk>
Date:   Wed Nov 24 16:14:52 2010 +0100

    zlib: cleanup, fix install for static only build
    
    Use 'make install' for installation, add a patch to make it work for
    static only builds, and add uninstall/clean targets while we're at it.
    
    Signed-off-by: Peter Korsgaard <jacmet@sunsite.dk>

I've fixed that now, thanks. The patch has also been sent upstream.

-- 
Bye, Peter Korsgaard

      reply	other threads:[~2010-12-12  8:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-12-07 21:57 [Buildroot] [PATCH] zlib: fix installing when static-only Mike Frysinger
2010-12-11 21:53 ` Peter Korsgaard
2010-12-12  3:52   ` Mike Frysinger
2010-12-12  8:11     ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxobl8bd.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox