Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <jacmet@uclibc.org>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 3/4] gstreamer: drop BR2_USE_WCHAR dependency (already required by libglib2)
Date: Sat, 05 Jun 2010 22:09:55 +0200	[thread overview]
Message-ID: <87mxv9nsvg.fsf@macbook.be.48ers.dk> (raw)
In-Reply-To: <1275767424.9566.30.camel@coalu.atr> (Lionel Landwerlin's message of "Sat, 05 Jun 2010 21:50:24 +0200")

>>>>> "Lionel" == Lionel Landwerlin <llandwerlin@gmail.com> writes:

Hi,

 >> > -	depends on BR2_USE_WCHAR # glib2
 >> 
 >> Why ? All packages that depend on libglib2 and therefore on gettext
 >> should depend on BR2_USE_WCHAR. See
 >> b730010c90a127746bada3d537eb0e204cba5988.
 >> 
 >> Is this dependency causing any problems ?
 >> 
 >> Thomas

 Lionel> Hi Thomas,

 Lionel> I don't understand why gstreamer should depend on BR2_USE_WCHAR and
 Lionel> BR2_PACKAGE_LIBGLIB2 if libglib2 already depends on BR2_USE_WCHAR.
 Lionel> It sounds like a repetition to me, isn't it ?

The problem is that gstreamer selects libglib2, it doesn't depend on it
- And select ignores dependencies (E.G. you can enable gstreamer in
menuconfig even if you haven't enabled wchar in the toolchain, because
kconfig doesn't check the dependencies of the things that gets
'select'-ed.

So nack.

-- 
Bye, Peter Korsgaard

  reply	other threads:[~2010-06-05 20:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-06-05 18:03 [Buildroot] [pull-request] A few fixes on gstreamer llandwerlin at gmail.com
2010-06-05 18:03 ` [Buildroot] [PATCH 1/4] bison: added host rules llandwerlin at gmail.com
2010-06-05 19:32   ` Thomas Petazzoni
2010-06-05 19:37     ` Thomas Petazzoni
2010-06-05 18:03 ` [Buildroot] [PATCH 2/4] gstreamer: Added host-flex and host-bison dependencies llandwerlin at gmail.com
2010-06-05 19:33   ` Thomas Petazzoni
2010-06-05 18:03 ` [Buildroot] [PATCH 3/4] gstreamer: drop BR2_USE_WCHAR dependency (already required by libglib2) llandwerlin at gmail.com
2010-06-05 19:31   ` Thomas Petazzoni
2010-06-05 19:50     ` Lionel Landwerlin
2010-06-05 20:09       ` Peter Korsgaard [this message]
2010-06-05 18:03 ` [Buildroot] [PATCH 4/4] gstreamer: remove --disable-registry from configure options llandwerlin at gmail.com
2010-06-08 21:24   ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mxv9nsvg.fsf@macbook.be.48ers.dk \
    --to=jacmet@uclibc.org \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox