[Buildroot] svn commit: trunk/buildroot/package/icu

[Peter Korsgaard <jacmet@uclibc.org>]

>>>>> "Daniel" == Daniel James Laird <daniel.j.laird@nxp.com> writes:

Hi,

 >> I'm not familiar with the external toolchain stuff, but don't you
 >> already now need to configure buildroot to match the toolchain
 >> settings (ipv6, largefile, locales, c++ support and so on?). If not,
 >> how is that handled?

 Daniel> It is currently setting stuff under
 Daniel> toolchain/external-toolchain/Config.in.2

Ahh ok.

 >> I guess it's already broken then ;) There's several packages
 >> depending on locales/c++/wchar stuff.

 Daniel> Yep, seems like what I shall do is add the options
 Daniel> BR2_LOCALE, BR2_USE_WCHAR and BR2_INSTALL_LIBSTDCPP.

Seems so.

 Daniel> Quick question, currently
 Daniel> toolchain/external-toolchain/Config.in.2 is setting
 Daniel> BR2_GCC_CROSS_CXX which means build a working C++ compiler
 Daniel> (in buildroot toolchain case) or I have a working C++
 Daniel> compiler (in external toolchain usecase).  So should this be
 Daniel> changed to BR2_INSTALL_LIBSTDCPP as we seem to be using this
 Daniel> second option to dictate whether some packages can be built
 Daniel> (qt/icu etc) or should we instead be checking against
 Daniel> BR2_GCC_CROSS_CXX in the packages that require C++ compiler
 Daniel> support

Well, these things date back to before my time - I'm not quite sure
why we have 2 config settings for C++, and if C++ support without
libstdc++ makes any sense, but the best approach indeed seems to be to
add a LIBSTDCPP option as well (You can make it a hidden option that
get's selected by the CROSS_CXX if you want to).

-- 
Bye, Peter Korsgaard