Buildroot Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Cc: Alexander Dahl <post@lespocky.de>,
	Fabrice Fontaine <fontaine.fabrice@gmail.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/putty: fix arm uclibc build
Date: Fri, 22 Mar 2024 21:10:38 +0100	[thread overview]
Message-ID: <87o7b610zl.fsf@48ers.dk> (raw)
In-Reply-To: <2aeb2daf-fecd-4307-b46b-76ce2829a798@mind.be> (Arnout Vandecappelle via buildroot's message of "Wed, 20 Mar 2024 20:52:56 +0100")

>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:

 > On 19/03/2024 21:06, Fabrice Fontaine wrote:
 >> Fix the following arm uclibc build failure raised since bump to version
 >> 0.78 in commit 5673ea3ce4d4dd721bb17fc8d5b1283f5c1080b4 which wrongly
 >> removed patch because file was renamed. Patch was sent upstream in 2021
 >> but rejected, even a second iteration defining AT_HWCAP2 to 26 if needed
 >> was also rejected.
 >> Fixes: 5673ea3ce4d4dd721bb17fc8d5b1283f5c1080b4
 >> - http://autobuild.buildroot.org/results/547d1c0e8a89e1e4b601aa756d26886bfc3d586f
 >> Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> ---
 >> ...-arm_arch_queries.h-fix-uclibc-build.patch | 40 +++++++++++++++++++
 >> 1 file changed, 40 insertions(+)
 >> create mode 100644 package/putty/0001-unix-utils-arm_arch_queries.h-fix-uclibc-build.patch
 >> diff --git
 >> a/package/putty/0001-unix-utils-arm_arch_queries.h-fix-uclibc-build.patch
 >> b/package/putty/0001-unix-utils-arm_arch_queries.h-fix-uclibc-build.patch
 >> new file mode 100644
 >> index 0000000000..f6b5fe6f91
 >> --- /dev/null
 >> +++ b/package/putty/0001-unix-utils-arm_arch_queries.h-fix-uclibc-build.patch
 >> @@ -0,0 +1,40 @@
 >> +From 2631c745f986b356fbe5e1d418cff63b46134df6 Mon Sep 17 00:00:00 2001
 >> +From: Fabrice Fontaine <fontaine.fabrice@gmail.com>
 >> +Date: Tue, 19 Mar 2024 20:37:33 +0100
 >> +Subject: [PATCH] unix/utils/arm_arch_queries.h: fix uclibc build
 >> +
 >> +Build on uclibc is broken since version 0.75 and commit
 >> +65383082bf0c49cec63f4b36001a40bd9b13edf6 because AT_HWCAP2 is used
 >> +even if <sys/auxv.h> is not available:
 >> +
 >> +/home/buildroot/autobuild/run/instance-3/output-1/build/putty-0.80/unix/utils/arm_arch_queries.c:
 >> In function 'platform_aes_neon_available':
 >> +/home/buildroot/autobuild/run/instance-3/output-1/build/putty-0.80/unix/utils/arm_arch_queries.c:18:22:
 >> error: 'AT_HWCAP2' undeclared (first use in this function)
 >> +   18 |     return getauxval(AT_HWCAP2) & HWCAP2_AES;
 >> +      |                      ^~~~~~~~~
 >> +
 >> +To fix this build failure, include <elf.h>
 >> +
 >> +Fixes:
 >> + - http://autobuild.buildroot.org/results/547d1c0e8a89e1e4b601aa756d26886bfc3d586f
 >> +
 >> +Signed-off-by: Fabrice Fontaine <fontaine.fabrice@gmail.com>

 >  There's no Upstream: tag, which makes check-package fail. Previously,
 >  the patch was simply ignored, but instead I added an Upstream: tag
 >  that says it was rejected.

 >  Applied to master with that fixed,thanks.

Committed to 2024.02.x, 2023.02.x and 2023.11.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

      reply	other threads:[~2024-03-22 20:10 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-03-19 20:06 [Buildroot] [PATCH 1/1] package/putty: fix arm uclibc build Fabrice Fontaine
2024-03-20 19:52 ` Arnout Vandecappelle via buildroot
2024-03-22 20:10   ` Peter Korsgaard [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7b610zl.fsf@48ers.dk \
    --to=peter@korsgaard.com \
    --cc=buildroot@buildroot.org \
    --cc=fontaine.fabrice@gmail.com \
    --cc=post@lespocky.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox