From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from smtp4.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 391BFC47DD9 for ; Sun, 25 Feb 2024 08:02:17 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp4.osuosl.org (Postfix) with ESMTP id D7936401C0; Sun, 25 Feb 2024 08:02:16 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp4.osuosl.org ([127.0.0.1]) by localhost (smtp4.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 06XvIgJkWf3i; Sun, 25 Feb 2024 08:02:16 +0000 (UTC) X-Comment: SPF check N/A for local connections - client-ip=140.211.166.34; helo=ash.osuosl.org; envelope-from=buildroot-bounces@buildroot.org; receiver= DKIM-Filter: OpenDKIM Filter v2.11.0 smtp4.osuosl.org D1534406B0 Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by smtp4.osuosl.org (Postfix) with ESMTP id D1534406B0; Sun, 25 Feb 2024 08:02:15 +0000 (UTC) Received: from smtp2.osuosl.org (smtp2.osuosl.org [140.211.166.133]) by ash.osuosl.org (Postfix) with ESMTP id 06BDE1BF232 for ; Sun, 25 Feb 2024 08:02:15 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by smtp2.osuosl.org (Postfix) with ESMTP id 0031F405F2 for ; Sun, 25 Feb 2024 08:02:14 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from smtp2.osuosl.org ([127.0.0.1]) by localhost (smtp2.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id elnWFL1YX9xv for ; Sun, 25 Feb 2024 08:02:13 +0000 (UTC) Received-SPF: Pass (mailfrom) identity=mailfrom; client-ip=2001:4b98:dc4:8::224; helo=relay4-d.mail.gandi.net; envelope-from=peter@korsgaard.com; receiver= DMARC-Filter: OpenDMARC Filter v1.4.2 smtp2.osuosl.org 7858F405CC DKIM-Filter: OpenDKIM Filter v2.11.0 smtp2.osuosl.org 7858F405CC Received: from relay4-d.mail.gandi.net (relay4-d.mail.gandi.net [IPv6:2001:4b98:dc4:8::224]) by smtp2.osuosl.org (Postfix) with ESMTPS id 7858F405CC for ; Sun, 25 Feb 2024 08:02:13 +0000 (UTC) Received: by mail.gandi.net (Postfix) with ESMTPSA id E3856E0007; Sun, 25 Feb 2024 08:02:09 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1re9Sa-00E2f0-2z; Sun, 25 Feb 2024 09:02:08 +0100 From: Peter Korsgaard To: Fabrice Fontaine References: <20240224213008.670294-1-fontaine.fabrice@gmail.com> Date: Sun, 25 Feb 2024 09:02:08 +0100 In-Reply-To: <20240224213008.670294-1-fontaine.fabrice@gmail.com> (Fabrice Fontaine's message of "Sat, 24 Feb 2024 22:30:08 +0100") Message-ID: <87o7c5rmyn.fsf@48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) MIME-Version: 1.0 X-GND-Sasl: peter@korsgaard.com X-Mailman-Original-Authentication-Results: smtp2.osuosl.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Subject: Re: [Buildroot] [PATCH 1/1] package/openssh: fix linux-pam select X-BeenThere: buildroot@buildroot.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Adam Duskett , buildroot@buildroot.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: buildroot-bounces@buildroot.org Sender: "buildroot" >>>>> "Fabrice" == Fabrice Fontaine writes: > Commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb forgot to handle > linux-pam dependencies resulting in the following build failure: > WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM > Depends on [n]: BR2_ENABLE_LOCALE [=n] && BR2_USE_WCHAR [=n] && !BR2_STATIC_LIBS [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=y] > Selected by [y]: > - BR2_PACKAGE_OPENSSH [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION [=y] > WARNING: unmet direct dependencies detected for BR2_PACKAGE_LINUX_PAM > Depends on [n]: BR2_ENABLE_LOCALE [=n] && BR2_USE_WCHAR [=n] && !BR2_STATIC_LIBS [=y] && BR2_USE_MMU [=y] && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 [=y] > Selected by [y]: > - BR2_PACKAGE_OPENSSH [=y] && BR2_USE_MMU [=y] && BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION [=y] > [...] > configure: error: in `/home/autobuild/autobuild/instance-12/output-1/build/linux-pam-1.6.0': > configure: error: failed to find dlopen > Fixes: 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb > - http://autobuild.buildroot.org/results/c0aac8bed08850e07cb94f501d754c3c64cdfe07 > Signed-off-by: Fabrice Fontaine > --- > package/openssh/Config.in | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > diff --git a/package/openssh/Config.in b/package/openssh/Config.in > index a3038ba01f..c108569547 100644 > --- a/package/openssh/Config.in > +++ b/package/openssh/Config.in > @@ -1,7 +1,10 @@ > config BR2_PACKAGE_OPENSSH > bool "openssh" > depends on BR2_USE_MMU # fork() > - select BR2_PACKAGE_LINUX_PAM if BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION > + select BR2_PACKAGE_LINUX_PAM if \ > + BR2_PACKAGE_REFPOLICY_UPSTREAM_VERSION && \ > + BR2_ENABLE_LOCALE && BR2_USE_WCHAR && \ > + !BR2_STATIC_LIBS && BR2_TOOLCHAIN_GCC_AT_LEAST_4_9 This stops kconfig from complaining, but does a openssh + refpolicy build without (E.G. ) locale support then actually work? Judging from: commit 2c5a82a29ceb382d53ccb08ffd34a92c142cadbb Author: Adam Duskett Date: Mon Oct 9 16:34:40 2023 +0200 package/openssh: select linux-pam if refpolicy upstream is selected linux-pam is required to login via OpenSSH if the upstream refpolicy for SELinux is enaabled, as linux-pam handles changing user contexts. If a user wants to make their own policy and use a refpolicy via git, we of course should let them do so. As such, only select linux-pam if the upstream version of refpolicy is selected. I am not sure what the proper solution is for situations where pam is not available? Adam? -- Bye, Peter Korsgaard _______________________________________________ buildroot mailing list buildroot@buildroot.org https://lists.buildroot.org/mailman/listinfo/buildroot