Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix rule order for re{install, build, configure}

From: Peter Korsgaard <peter@korsgaard.com>
To: Arnout Vandecappelle via buildroot <buildroot@buildroot.org>
Cc: James Hilliard <james.hilliard1@gmail.com>,
	Thomas Petazzoni <thomas.petazzoni@bootlin.com>
Subject: Re: [Buildroot] [PATCH 1/1] package/pkg-generic.mk: fix rule order for re{install, build, configure}
Date: Fri, 13 Oct 2023 16:41:48 +0200	[thread overview]
Message-ID: <87o7h24mab.fsf@48ers.dk> (raw)
In-Reply-To: <dfe9844e-5208-4d19-3af9-0faf8c0a5abf@mind.be> (Arnout Vandecappelle via buildroot's message of "Sun, 1 Oct 2023 18:05:19 +0200")

>>>>> "Arnout" == Arnout Vandecappelle via buildroot <buildroot@buildroot.org> writes:

 >  Hi James,
 > On 18/10/2022 05:46, James Hilliard wrote:
 >> These command rely on the clean operations being first so that the
 >> stamp files being deleted will rebuild the targets.
 >> The execution ordering of the clean and rebuild operations may
 >> change, for example if --shuffle=reversed is set.
 >> To ensure the evaluation order is always correct use double colon
 >> rules to make the evaluation order explicit as per make docs:
 >> The double-colon rules for a target are executed in the order they
 >> appear in the makefile.

 >  As noted in earlier discussions, this feels a bit hackish and it's
 >  not clear if this behaviour is going to be kept in future versions of
 > make.

 >  Since make 4.4, however, there's a better solution: it introduced a
 >  .WAIT phony target that enforces the ordering of dependencies. So I
 > instead made a commit[1] that uses that approach.

Committed to 2023.02.x and 2023.08.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot