Re: [Buildroot] [PATCH] package/pcm-tools: fix github-download

[Peter Korsgaard <peter@korsgaard.com>]

>>>>> "Yann" == Yann E MORIN <yann.morin.1998@free.fr> writes:

 > The pcm-tools package contains a version.h with git attributes:
 >     $ cat version.h
 >     #define PCM_VERSION " ($Format:%ci ID=%h$)"

 >     $ man 5 gitattributes
 >        Creating an archive
 >          export-subst
 >            If the attribute export-subst is set for a file then Git
 >            will expand several placeholders when adding this file to
 >            an archive. The expansion depends on the availability of
 >            a commit ID, i.e., if git-archive(1) has been given a tree
 >            instead of a commit or a tag then no replacement will be
 >            done. The placeholders are the same as those for the option
 >            --pretty=format: of git-log(1), except that they need to be
 >            wrapped like this: $Format:PLACEHOLDERS$ in the file. E.g.
 >            the string $Format:%H$ will be replaced by the commit hash.

 > So, the archive generated by github has changed since we updated
 > pcm-tools in 2021-12-08 with commit d1d93d488c76 (package/pcm-tools:
 > bump to version 202110). The downlad was still OK in 2022-01-04 [0]
 > but has been failing at least since 202-08-25 [1].

 > Since the archive is generated on the github side, there is not much we
 > can do to fix this up.

 > We switch over to using git to do the download, and we generate the
 > archive localy, which we know is reproducible.

 > We fix the version.h so that it contains the same string as the backup
 > tarball we host on s.b.o.

 > There are three other files in pcm-tools that have git attributes, to
 > exclude them from the generated archive, all pertaining to CI/CD stuff:
 >     .cirrus.yml export-ignore
 >     .gitlab-ci.yml export-ignore
 >     .travis.yml export-ignore

 > We don't remove them, because they have no impact on the build, and they
 > are anyway already present in the archive by the time we could act on it
 > anyway...

 > [0] http://autobuild.buildroot.org/results/127/1276a3d49c8848039f034e7f03632df365097e94/
 > [1] http://autobuild.buildroot.org/results/8bb/8bbf9c36af332bbf5e7c1abcbb594a0b231ef97e/

 > Reported-by: Woody Douglass <wdouglass@carnegierobotics.com>
 > Reported-by: Thomas Petazzoni <thomas.petazzoni@bootlin.com>
 > Signed-off-by: Yann E. MORIN <yann.morin.1998@free.fr>

Committed to 2023.02.x and 2023.05.x, thanks.

-- 
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot