From: Peter Korsgaard <peter@korsgaard.com>
To: Luca Ceresoli <luca@lucaceresoli.net>
Cc: Neal Frager <neal.frager@xilinx.com>,
giulio.benetti@benettiengineering.com, michal.simek@xilinx.com,
buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH v6 1/2] configs/zynqmp_zcu106: bump ATF/U-Boot/Linux to Xilinx 2022
Date: Wed, 23 Feb 2022 11:05:19 +0100 [thread overview]
Message-ID: <87o82x6gps.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <87bkzcnqpx.fsf@dell.be.48ers.dk> (Peter Korsgaard's message of "Sat, 12 Feb 2022 14:45:30 +0100")
>>>>> "Peter" == Peter Korsgaard <peter@korsgaard.com> writes:
>>> +#endif
>>> +{
>>> + /**********************************************************************/
>>> + /* HEADER */
>>> + 2, /* Number of remaining words in the header */
>>> + 8, /* Number of sections included in config object */
>>> + 1U, /* Type of config object as base */
>> Here's where you have manually replaced "PM_CONFIG_OBJECT_TYPE_BASE" ->
>> "1U", right? Well, it should be well noted in the commit message. This
>> file is supposed to be generated by Vitis and used untouched, any manual
>> edits whould be documented.
>> Or, even better, use the U-Boot patch I sent (see other e-mail I just
>> wrote) and use an unmodified pm_cfg_obj.c
> Ups, I applied the series before seeing this comment. Lets handle it as
> a followup patch for zcu102/106.
Neal, will you send a followup patch for this?
--
Bye, Peter Korsgaard
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot
next prev parent reply other threads:[~2022-02-23 10:05 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-11 14:44 [Buildroot] [PATCH v6 1/2] configs/zynqmp_zcu106: bump ATF/U-Boot/Linux to Xilinx 2022 Neal Frager
2022-02-11 14:44 ` [Buildroot] [PATCH v6 2/2] add configs/zynqmp_zcu102_defconfig Neal Frager
2022-02-12 13:43 ` Peter Korsgaard
2022-02-12 13:13 ` [Buildroot] [PATCH v6 1/2] configs/zynqmp_zcu106: bump ATF/U-Boot/Linux to Xilinx 2022 Luca Ceresoli
2022-02-12 13:18 ` Neal Frager
2022-02-12 13:45 ` Peter Korsgaard
2022-02-12 14:47 ` Neal Frager
2022-02-23 10:05 ` Peter Korsgaard [this message]
2022-02-23 12:55 ` Neal Frager
2022-02-12 13:42 ` Peter Korsgaard
2022-02-23 10:04 ` Peter Korsgaard
2022-02-23 11:02 ` Neal Frager
2022-02-23 11:11 ` Peter Korsgaard
2022-02-23 11:29 ` Neal Frager
2022-02-23 11:18 ` Peter Korsgaard
2022-02-23 11:27 ` Neal Frager
2022-02-23 11:07 ` Neal Frager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o82x6gps.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=buildroot@buildroot.org \
--cc=giulio.benetti@benettiengineering.com \
--cc=luca@lucaceresoli.net \
--cc=michal.simek@xilinx.com \
--cc=neal.frager@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox